Skip to content

vendor: github.com/moby/sys/sequential v0.7.0#7035

Merged
vvoland merged 1 commit into
docker:masterfrom
thaJeztah:bump_sequential
Jun 10, 2026
Merged

vendor: github.com/moby/sys/sequential v0.7.0#7035
vvoland merged 1 commit into
docker:masterfrom
thaJeztah:bump_sequential

Conversation

@thaJeztah

Copy link
Copy Markdown
Member
  • update minimum go version to 1.24
  • use os.OpenFile with O_FILE_FLAG_SEQUENTIAL_SCAN on Go 1.26+

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

- update minimum go version to 1.24
- use os.OpenFile with O_FILE_FLAG_SEQUENTIAL_SCAN on Go 1.26+

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@docker-agent docker-agent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR vendors github.com/moby/sys/sequential v0.7.0, splitting the Windows implementation into two build-tag-gated files:

  • sequential_windows_go126.go (//go:build windows && go1.26): uses os.OpenFile with windows.O_FILE_FLAG_SEQUENTIAL_SCAN — a new fast path for Go 1.26+.
  • sequential_windows_pre126.go (//go:build windows && !go1.26): retains the existing manual CreateFile-based implementation for Go < 1.26.
  • sequential_windows.go: correctly contains only shared API wrappers and CreateTemp helpers — no symbol conflicts.
  • sequential_unix.go: CreateTemp correctly delegates to os.CreateTemp.
  • vendor.mod / vendor.sum / vendor/modules.txt are consistent with the new v0.7.0 version.

No high- or medium-severity issues found. A few low-severity observations (informational only):

  1. The go1.26 build tag targets a Go version not yet released; the new fast path is effectively dormant until Go 1.26 ships — this is intentional and expected for forward-compatible vendoring.
  2. The perm parameter is passed through to os.OpenFile in the go1.26 path but silently ignored in the pre-1.26 path (_); this is consistent with the pre-existing behavior and the constraints of the CreateFile API.
  3. The pre-1.26 path's silent perm-ignore is a pre-existing limitation carried forward, not a regression.

The implementation is correct and the split is clean.

@thaJeztah

Copy link
Copy Markdown
Member Author

@docker-agent go1.26 has been released for some months now; your information looks severely outdated

@vvoland vvoland merged commit 83963b7 into docker:master Jun 10, 2026
119 of 120 checks passed
@thaJeztah thaJeztah deleted the bump_sequential branch June 10, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants