vendor: go.opentelemetry.io/otel v1.44.0, go.opentelemetry.io/contrib v0.69.0#7037
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
… v0.69.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docker-agent
reviewed
Jun 9, 2026
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR is a clean vendor dependency bump:
go.opentelemetry.io/otel→ v1.44.0go.opentelemetry.io/contrib→ v0.69.0- Related gRPC and semconv updates
Both diff chunks were reviewed in full. The added code introduces consistent, correct patterns throughout:
- Early-exit
.Enabled(ctx)guards before recording metrics (correct performance optimization) clear(*o)before*o = (*o)[:0]insync.Pooldefer blocks (correct GC hygiene, prevents stale interface pointer retention)- New
*Observablewrapper types all follow the established nil-meter guard pattern - Explicit histogram bucket boundaries added to duration instruments
- All new constructors correctly propagate errors and fall back to noop instruments on failure
No bugs, logic errors, nil dereferences, race conditions, or resource leaks were found in any added code.
vvoland
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)