feat(deps): github.com/docker/cli v29.8.0 - #14138
Conversation
|
Just testing the RC |
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR performs a routine dependency bump, upgrading github.com/moby/buildkit from v0.32.2 to v0.33.0-rc1, along with transitive updates to containerd (v2.3.4), OTel core (v1.45.0), OTel contrib (v0.70.0), grpc (v1.83.2), golang.org/x/crypto (v0.55.0), golang.org/x/net (v0.58.0), and several other indirect dependencies.
Analysis summary:
- The moby/buildkit v0.33.0-rc1 RC pin is intentional: docker/compose and buildkit share the same Docker/Moby org, and this project has an established pattern of tracking RC versions for integration testing (containerd/platforms was already at v1.0.0-rc.4, now v1.0.0-rc.5). Compose is distributed as a compiled binary, not a library, so the RC pin does not propagate as a go module dependency to end users.
- OTel version alignment is correct: all core packages move to v1.45.0 and contrib packages to v0.70.0 consistently.
- Security-relevant packages (golang.org/x/crypto, golang.org/x/net) are incremental updates with no known outstanding CVEs at the target versions.
- grpc v1.83.2 and protobuf v1.36.12 (GA, not pre-release) align correctly with the updated genproto packages.
- No indirect dependency downgrades or version conflicts detected.
No actionable issues found.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@thaJeztah can you rebase it and fix the conflicts please? |
25cf3d8 to
1b5641a
Compare
|
@glours rebased and updated to rc2 - wasn't sure if you already wanted to have it un-drafted, because they're still rc's |
1b5641a to
1d6db99
Compare
1d6db99 to
f95eb29
Compare
f95eb29 to
7c76019
Compare
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Clean dependency-only bump. The diff updates github.com/docker/cli from v29.7.2 to v29.8.0 and transitively bumps several related packages (moby/moby/api, moby/moby/client, docker/docker-credential-helpers, docker/go-connections, fvbommel/sortorder, mattn/go-runewidth, santhosh-tekuri/jsonschema/v6). All changes are self-consistent: direct and indirect dependency versions are updated together, semver expectations are met, and no version conflicts or orphaned transitive pins are present.
7c76019 to
c1f9849
Compare
c1f9849 to
a376339
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
a376339 to
d9a81b0
Compare
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did