[automated] docs: fix incorrect claim about compressed layer deduplication in containerd image store#24496
[automated] docs: fix incorrect claim about compressed layer deduplication in containerd image store#24496dvdksn wants to merge 2 commits intodocker:mainfrom
Conversation
…tainerd image store (fixes docker#24476)
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR correctly fixes a factual inaccuracy in the documentation. The original text incorrectly stated that the containerd image store duplicates compressed layers across images ("each image stores its own compressed version of shared layers").
The corrected text accurately explains that:
- Compressed layers ARE deduplicated by digest in the content store (same as legacy drivers)
- The overhead comes from dual storage (compressed + unpacked), not from duplication
The fix improves technical accuracy and aligns with how containerd's content-addressed storage actually works. No documentation quality issues found.
|
I suggest removing the paragraph starting with "This difference is particularly noticeable with multiple images sharing the same base layers" altogether, as the opening sentence contradicts the explanation. Since shared layers are deduplicated, there’s nothing particularly noticeable here - the real difference is the dual storage (compressed and unpacked) of each unique layer, which is already covered in the previous paragraphs. |
The paragraph opened with "This difference is particularly noticeable with multiple images sharing the same base layers" — but then went on to explain that shared layers are deduplicated just like with legacy drivers. The opening sentence contradicts the explanation: since deduplication applies equally, there is nothing particularly noticeable about the shared-layer case. Remove the paragraph. The dual-storage overhead per unique layer is already explained in the preceding paragraph. Per review comment from mike-sul. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
Good catch, @mike-sul — removed the paragraph entirely. The opening sentence was indeed self-defeating: if deduplication works the same as legacy drivers, there's nothing particularly noticeable about the shared-layer case. The dual-storage explanation in the preceding paragraph is sufficient. |
Summary
The "Disk space usage" section incorrectly stated that the containerd image store stores per-image copies of shared compressed layers. This is factually wrong.
The fix replaces the incorrect paragraph with an accurate description of both deduplication behavior and the real source of overhead.
Closes #24476