Skip to content

dhi: clean up subscription table#25042

Open
craig-osterhout wants to merge 1 commit into
docker:mainfrom
craig-osterhout:dhi-table-fix
Open

dhi: clean up subscription table#25042
craig-osterhout wants to merge 1 commit into
docker:mainfrom
craig-osterhout:dhi-table-fix

Conversation

@craig-osterhout
Copy link
Copy Markdown
Contributor

Description

The multi-line ELS cell at the end of the table was wonky looking, and the customizations row was inconsistent with checkmarks.

Updated ELS cell to single line.
Updated customizations row to have checkmarks.

Related issues or tickets

ENGDOCS-3298

Reviews

  • Editorial review

Signed-off-by: Craig Osterhout <[email protected]>
@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 38dd132
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6a0372f448fc280008c280e2
😎 Deploy Preview https://deploy-preview-25042--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@craig-osterhout craig-osterhout requested a review from a team May 12, 2026 18:35
@craig-osterhout craig-osterhout added the status/review Pull requests that are ready for review label May 12, 2026
Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The two changed lines clean up the subscription comparison table as described:

  • Customizations row: Adding ✅ checkmarks before "Up to 5" and "Unlimited" is consistent with the ✅/❌ pattern used across all other rows.
  • ELS row: Collapsing the multi-line cell (which used <br> HTML tags) into a single-line ✅ +5 years of hardened updates simplifies the table layout. Readers seeking full ELS details are directed to the external comparison page linked immediately below.

No style violations, no content accuracy issues, no missing redirects. Changes match the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dhi status/review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants