Skip to content

fix: chip typeahead value placement#1748

Closed
bitpshr wants to merge 3 commits intomasterfrom
fix/chip-placement
Closed

fix: chip typeahead value placement#1748
bitpshr wants to merge 3 commits intomasterfrom
fix/chip-placement

Conversation

@bitpshr
Copy link
Copy Markdown
Member

@bitpshr bitpshr commented May 3, 2021

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • For new widgets, an entry has been added to the .dojorc
  • For new widgets, theme.variant() is added to the root domnode
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Description:

This pull request fixes an issue where chip values were not wrapped inline with the input.

Resolves #1742

@bitpshr bitpshr requested review from agubler and matt-gadd May 3, 2021 16:49
@vercel
Copy link
Copy Markdown

vercel bot commented May 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/GDd3j7fhCSaV8sWymhHmoCs3rGo1
✅ Preview: https://dojowidgets-git-fix-chip-placement-dojo1.vercel.app

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/89UZhuQZwrEKXrruXhiayKz4WjSH
✅ Preview: https://widget-test-docs-git-fix-chip-placement-dojo1.vercel.app

@bitpshr bitpshr marked this pull request as draft May 3, 2021 16:52
@codecov
Copy link
Copy Markdown

codecov bot commented May 3, 2021

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.45%. Comparing base (7c8e49e) to head (ef0788c).
⚠️ Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
src/text-input/index.tsx 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1748      +/-   ##
==========================================
- Coverage   90.46%   90.45%   -0.02%     
==========================================
  Files          94       94              
  Lines        5152     5155       +3     
  Branches     1406     1408       +2     
==========================================
+ Hits         4661     4663       +2     
  Misses        241      241              
- Partials      250      251       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

import HelperText from '../helper-text/index';
import Label from '../label/index';
import * as css from '../theme/default/text-input.m.css';
import { isArray } from 'util';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is a correct import


let leadingElements;
if (leading) {
leadingElements = isArray(leading) ? leading : [leading];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array.isArray

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEMPORARY INSANITY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ChipTypeahead wraps input to new line

2 participants