Fix OneBranch Official NuGet publish service connection#3995
Merged
paulmedynski merged 6 commits intomainfrom Mar 3, 2026
Merged
Fix OneBranch Official NuGet publish service connection#3995paulmedynski merged 6 commits intomainfrom
paulmedynski merged 6 commits intomainfrom
Conversation
paulmedynski
added
the
Area\Engineering
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Azure DevOps pipeline definitions to correct the NuGet.org publish service connection used by OneBranch official releases, and adjusts trigger path filtering for PR/CI pipelines.
Changes:
- Update OneBranch variable
NuGetServiceConnectionto the intended ADO service connection name for NuGet pushes. - Exclude
eng/pipelines/onebranchfrom PR path triggers in the two PR validation pipelines. - Remove path-based CI trigger filtering so CI runs on all pushes to the configured branches.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/sqlclient-pr-project-ref-pipeline.yml | Adds PR path exclusion for eng/pipelines/onebranch. |
| eng/pipelines/sqlclient-pr-package-ref-pipeline.yml | Adds PR path exclusion for eng/pipelines/onebranch. |
| eng/pipelines/onebranch/variables/common-variables.yml | Sets the OneBranch NuGet publish service connection name. |
| eng/pipelines/dotnet-sqlclient-ci-project-reference-pipeline.yml | Removes CI trigger path filters (branch-only triggers). |
| eng/pipelines/dotnet-sqlclient-ci-package-reference-pipeline.yml | Removes CI trigger path filters (branch-only triggers). |
…cts contain multiple packages. - Fixed PR pipeline trigger paths.
paulmedynski
commented
Mar 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3995 +/- ##
==========================================
- Coverage 72.03% 64.56% -7.47%
==========================================
Files 287 282 -5
Lines 43149 66073 +22924
==========================================
+ Hits 31083 42663 +11580
- Misses 12066 23410 +11344
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…cards matching unintended artifacts.
… all the other packages.
paulmedynski
commented
Mar 3, 2026
cheenamalhotra
approved these changes
Mar 3, 2026
mdaigle
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The OneBranch Official pipeline contained a placeholder value for the service connection to use for NuGet pushes. Replaced it with the actual value we need to use.
I also excluded OneBranch pipeline files from PR triggers since they have no effect on PR checks, and removed all paths from the CI triggers since they should build on all pushes.