Merge | Not Supported Binaries / Test Targets by benrr101 · Pull Request #3997 · dotnet/SqlClient

benrr101 · 2026-03-04T19:08:13Z

Description

This PR consists of two main changes:

Add test targets to build2.proj

Expand upon the build parameter descriptions
Add targets for testing via dotnet
Targets are not wired up to anything yet, but they will be used soon

Generate "Not Supported" assemblies from common MDS

Add a new project to generate Not Supported assemblies, with much description and much explanation on how to use it
- This removes dependency on GenerateNotSupported.targets and ResolveContract.targets
Add GenAPI projects to solution for reference purposes they are not built with the solution
Add generated not supported source files to the .gitignore
Add build2.proj target that generates the not supported targets they are not wired up to anything yet, but they will be used soon
Build GenAPI as part of BuildMdsNotSupported target
- Don't worry about special paths for output of it, just dump it to the default bin output
- Only build for one target framework (net9.0 was chosen)
Update GenerateNotSupported.targets to pick up the changes to paths.

Msc Changes

Dump ref binaries to a better place in the artifacts folder
Strong name sign ref binaries
Bring back disabling common MDS net462 building when building for unix

Issues

N/A

Testing

Running targets locally work as expected. Hopefully there are no major issues with the pipelines, since most of the changes don't affect existing pipelines.

…targets

…project.

…ifacts"

…lution build

Copilot

Pull request overview

This PR makes two main changes: (1) adds test targets to build2.proj with detailed parameter documentation for running MDS tests via MSBuild, and (2) creates a new dedicated project (notsupported/) to generate "Not Supported" assemblies from the common MDS ref project using GenAPI, replacing the previous approach that was embedded in the netcore/netfx projects. Additional changes include strong-name signing for ref binaries, updated output paths for ref assemblies, conditional exclusion of net462 from Unix builds, and GenAPI project updates to target a single framework (net9.0).

Changes:

New notsupported/Microsoft.Data.SqlClient.csproj project and updated NotSupported.targets for generating PlatformNotSupportedException assemblies via GenAPI
Expanded build2.proj with test targets (TestMdsFunctional, TestMdsManual, TestMdsUnit), build targets (BuildMdsRef, BuildMdsNotSupported), and comprehensive parameter documentation
Conditional net462 exclusion on Unix, strong-name signing for ref binaries, and GenAPI project simplification to single net9.0 target

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
build2.proj	Major expansion: imports, test/build targets, detailed parameter docs
tools/targets/NotSupported.targets	Replaced old GenAPI variable setup with new paths/command, but Exec still uses old vars
src/Microsoft.Data.SqlClient/notsupported/Microsoft.Data.SqlClient.csproj	New project to generate Not Supported assemblies via GenAPI
src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj	Reordered TargetOs/TargetFrameworks, added signing, conditional net462 on Windows only
src/Microsoft.Data.SqlClient/ref/Microsoft.Data.SqlClient.csproj	Added strong-name signing and custom output path under artifacts/
tools/GenAPI/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj	Simplified to single net9.0 target, removed custom OutputPath
tools/GenAPI/Microsoft.Cci.Extensions/Microsoft.Cci.Extensions.csproj	Removed custom OutputPath
src/Microsoft.Data.SqlClient.sln	Added notsupported, GenAPI, and Cci.Extensions projects (no build)
.gitignore	Added pattern to ignore generated notsupported .cs files

build2.proj

src/Microsoft.Data.SqlClient/notsupported/Microsoft.Data.SqlClient.csproj

build2.proj

tools/targets/NotSupported.targets

src/Microsoft.Data.SqlClient/notsupported/Microsoft.Data.SqlClient.csproj

build2.proj

tools/targets/NotSupported.targets

…e projects themselves

Ignore trx test results from git

Adding conditional net462 stuff to stress test Directory.Build.props Adding TestUtilities reference to Azure test

Copilot

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 5 comments.

src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj

Copilot · 2026-03-04T23:37:35Z

build2.proj

+  <Target Name="BuildMdsNotSupported">
+    <PropertyGroup>
+      <DotNetCommand>
+        "$(DotNetPath)dotnet" build "$(GenApiPath)/Microsoft.DotNet.GenAPI.csproj"


Bug: $(GenApiPath) already ends with a trailing / (defined at line 155 as $(RepoRoot)tools/GenAPI/Microsoft.DotNet.GenAPI/), so this produces a double slash in the path: .../Microsoft.DotNet.GenAPI//Microsoft.DotNet.GenAPI.csproj.

Additionally, line 156 already defines $(GenApiProjectPath) as $(GenApiPath)Microsoft.DotNet.GenAPI.csproj for exactly this purpose, but it's not used here. Replace "$(GenApiPath)/Microsoft.DotNet.GenAPI.csproj" with "$(GenApiProjectPath)".

Suggested change

"$(DotNetPath)dotnet" build "$(GenApiPath)/Microsoft.DotNet.GenAPI.csproj"

"$(DotNetPath)dotnet" build "$(GenApiProjectPath)"

src/Microsoft.Data.SqlClient.Extensions/Azure/test/Azure.Test.csproj

build2.proj

Remove redundant strong naming from common MDS Fix typos as per copilot (why couldn't it find these the first time around??)

…life slightly easier

Copilot

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 6 comments.

Copilot · 2026-03-05T01:12:36Z

build2.proj

+      PackageVersionLogging
+      Applies to:     BuildMds, BuildMdsUnix, BuildMdsWindows
+                      TestMdsFunctiona, TestMdsManual
+      Description:    Specifies what version of the Microsoft.Data.SqlCLient.Logging to use


Spelling: "SqlCLient" should be "SqlClient" (lowercase 'l'), same as the occurrence at line 33.

Copilot · 2026-03-05T01:12:37Z

src/Microsoft.Data.SqlClient/ref/Microsoft.Data.SqlClient.csproj

+  <!-- Strong name signing ============================================= -->
+  <!-- When a signing key is specified, we will perform strong name assembly signing. -->
+  <PropertyGroup Condition="'$(SigningKeyPath)' != ''">
+    <SignAssembly>true</SignAssembly>
+    <AssemblyOriginatorKeyFile>$(SigningKeyPath)</AssemblyOriginatorKeyFile>
+  </PropertyGroup>
+


The strong name signing properties (SignAssembly, AssemblyOriginatorKeyFile) are already set by src/Directory.Build.props (lines 121-123), which this project inherits via MSBuild's automatic Directory.Build.props walk-up. This block is redundant. Consider removing it to keep the signing configuration centralized, or at minimum add a comment explaining why the duplication is intentional.

Suggested change





<PropertyGroup Condition="'$(SigningKeyPath)' != ''">

<SignAssembly>true</SignAssembly>

<AssemblyOriginatorKeyFile>$(SigningKeyPath)</AssemblyOriginatorKeyFile>

</PropertyGroup>

Copilot · 2026-03-05T01:12:37Z

build2.proj

+    <!--
+      PackageVersionLogging
+      Applies to:     BuildMds, BuildMdsUnix, BuildMdsWindows
+                      TestMdsFunctiona, TestMdsManual


Spelling: "TestMdsFunctiona" is missing the trailing "l" — should be "TestMdsFunctional".

Suggested change

TestMdsFunctiona, TestMdsManual

TestMdsFunctional, TestMdsManual

Copilot · 2026-03-05T01:12:37Z

build2.proj

+	<Target Name="BuildMds" DependsOnTargets="BuildMdsUnix;BuildMdsWindows;BuildMdsRef;BuildMdsNotSupported" />
+
+  <!--
+    BuildMdsNotSupportd: Builds a version of the MDS assemblies that always throws


Spelling: "BuildMdsNotSupportd" in the comment is missing the trailing "e" — should be "BuildMdsNotSupported".

Suggested change

BuildMdsNotSupportd: Builds a version of the MDS assemblies that always throws

BuildMdsNotSupported: Builds a version of the MDS assemblies that always throws

Copilot · 2026-03-05T01:12:37Z

build2.proj

+      <DotNetCommand>
+        "$(DotNetPath)dotnet" build "$(GenApiProjectPath)"
+          -p:Configuration=$(Configuration)
+      </DotNetCommand>
+      <!-- Convert more than one whitespace character into one space -->
+      <DotnetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(DotnetCommand), "\s+", " "))</DotnetCommand>


Bug: $(DotNetPath) (capital N) on lines 215 and 232 is inconsistently cased compared to the build parameter $(DotnetPath) (lowercase n) defined on line 27. While MSBuild properties are case-insensitive so this won't cause a runtime failure, the naming within this same target is self-inconsistent: the property is initially set as DotNetCommand (lines 214, 231) but the regex replace overwrites a differently-cased DotnetCommand (lines 219, 237). Although MSBuild treats these as the same property, please use consistent casing throughout for readability — the rest of the file uses DotnetCommand and DotnetPath.

Copilot · 2026-03-05T01:12:38Z

build2.proj

+      PackageVersionAbstractions
+      Applies to:     BuildMds, BuildMdsRef, BuildMdsUnix, BuildMdsWindows
+                      TestMdsFunctional, TestMdsManual
+      Description:    Specifies what version of the Microsoft.Data.SqlCLient.Abstractions to use


Spelling: "SqlCLient" should be "SqlClient" (lowercase 'l'). This appears in both the PackageVersionAbstractions and PackageVersionLogging parameter descriptions.

benrr101 added 11 commits March 4, 2026 12:55

Stubbing out additional targets for build2.proj

b0afd95

Fix issue with target OS and target frameworks in common MDS build

a7a9bf7

Adding targets to build2.proj for testing MDS, removing AKV provider …

4065b08

…targets

Adding build target for MDS ref project

83cc907

Get common ref project building to artifacts folder, a la common mds …

154b150

…project.

Add stub for notsupported project

04ebcb7

Add GenAPI projects to the solution file under notsupported folder

86e75e3

Move GenAPI output path to bin folder for project - they are not "art…

392723b

…ifacts"

Not supported assemblies are building via new project

1b406ce

Do not build not supported assembly and genapi projects as part of so…

a214c38

…lution build

Ignore the notsupported GenAPI files

406d810

benrr101 added this to the 7.0.0 milestone Mar 4, 2026

benrr101 requested a review from a team as a code owner March 4, 2026 19:08

benrr101 added the Common Project 🚮 Things that relate to the common project project label Mar 4, 2026

Copilot AI review requested due to automatic review settings March 4, 2026 19:08

github-project-automation bot added this to SqlClient Board Mar 4, 2026

github-project-automation bot moved this to To triage in SqlClient Board Mar 4, 2026

Copilot started reviewing on behalf of benrr101 March 4, 2026 19:08 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

benrr101 added 4 commits March 4, 2026 14:18

Comments from copilot

82d73ae

Remove Directory.Build.props and move target frameworks listing to th…

5c3e3c2

…e projects themselves

Conditionally enable net462 on Azure test project

7187e3e

Ignore trx test results from git

Removing Directory.Build.props from test/tools

a904283

Adding conditional net462 stuff to stress test Directory.Build.props Adding TestUtilities reference to Azure test

Copilot AI review requested due to automatic review settings March 4, 2026 23:28

Copilot started reviewing on behalf of benrr101 March 4, 2026 23:28 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

benrr101 added 2 commits March 4, 2026 18:18

Add trim docs for intellisense to ref project (just inline it)

3c45064

Remove redundant strong naming from common MDS Fix typos as per copilot (why couldn't it find these the first time around??)

Rework the package version arguments in build2.proj - this will make …

f47ae65

…life slightly easier

Copilot AI review requested due to automatic review settings March 5, 2026 01:03

Copilot started reviewing on behalf of benrr101 March 5, 2026 01:04 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

	"$(DotNetPath)dotnet" build "$(GenApiPath)/Microsoft.DotNet.GenAPI.csproj"
	"$(DotNetPath)dotnet" build "$(GenApiProjectPath)"

	TestMdsFunctiona, TestMdsManual
	TestMdsFunctional, TestMdsManual

	BuildMdsNotSupportd: Builds a version of the MDS assemblies that always throws
	BuildMdsNotSupported: Builds a version of the MDS assemblies that always throws

Conversation

benrr101 commented Mar 4, 2026

Description

Add test targets to build2.proj

Generate "Not Supported" assemblies from common MDS

Msc Changes

Issues

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants