Migrate StripEmbeddedLibraries from ILLink step#10871
Closed
Conversation
…peline Port StripEmbeddedLibraries from a custom ILLink linker step to an IAssemblyModifierPipelineStep so it runs as part of the post-trim AssemblyModifierPipeline instead. Write modified assemblies to a temp 'new/' subdirectory then immediately copy back using the same rename-to-backup pattern as MarshalMethodsAssemblyRewriter, avoiding conflicts from reading and writing assemblies in the same directory. Strip R2R (crossgen'd) metadata before writing so Mono.Cecil can handle mixed-mode assemblies without throwing NotSupportedException.
Member
Author
|
This doesn't work because it strips out the R2R (I just learned that the modifier pipeline runs after R2R for coreclr): #10891. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Trying out an alternative to #10695 that should involve fewer build changes)
Port StripEmbeddedLibraries from a custom ILLink linker step to an IAssemblyModifierPipelineStep so it runs as part of the post-trim AssemblyModifierPipeline instead.
Write modified assemblies to a temp 'new/' subdirectory then immediately copy back using the same rename-to-backup pattern as MarshalMethodsAssemblyRewriter, avoiding conflicts from reading and writing assemblies in the same directory.
Strip R2R (crossgen'd) metadata before writing so Mono.Cecil can handle mixed-mode assemblies without throwing NotSupportedException.