Skip to content

Remove unnecessary Task.Run from androidtest template #11339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonrozsival merged 1 commit into from
May 14, 2026
Merged

Remove unnecessary Task.Run from androidtest template #11339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 26 additions & 29 deletions src/Microsoft.Android.Templates/androidtest/TestInstrumentation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,41 +20,38 @@ public override void OnCreate(Bundle? arguments)
Start();
}

public override void OnStart()
public override async void OnStart()
{
base.OnStart();

Task.Run(async () =>
var consumer = new ResultConsumer(this);
var bundle = new Bundle();
try
{
var consumer = new ResultConsumer(this);
var bundle = new Bundle();
try
{
var writeablePath = Application.Context.GetExternalFilesDir(null)?.AbsolutePath ?? Path.GetTempPath();
var resultsPath = Path.Combine(writeablePath, "TestResults");
var builder = await TestApplication.CreateBuilderAsync([
"--results-directory", resultsPath,
"--report-trx"
]);
builder.AddMSTest(() => [GetType().Assembly]);
builder.AddTrxReportProvider();
builder.TestHost.AddDataConsumer(_ => consumer);
var writeablePath = Application.Context.GetExternalFilesDir(null)?.AbsolutePath ?? Path.GetTempPath();
var resultsPath = Path.Combine(writeablePath, "TestResults");
var builder = await TestApplication.CreateBuilderAsync([
"--results-directory", resultsPath,
"--report-trx"
]);
builder.AddMSTest(() => [GetType().Assembly]);
builder.AddTrxReportProvider();
builder.TestHost.AddDataConsumer(_ => consumer);

using ITestApplication app = await builder.BuildAsync();
await app.RunAsync();
using ITestApplication app = await builder.BuildAsync();
await app.RunAsync();

bundle.PutInt("passed", consumer.Passed);
bundle.PutInt("failed", consumer.Failed);
bundle.PutInt("skipped", consumer.Skipped);
bundle.PutString("resultsPath", consumer.TrxReportPath);
Finish(Result.Ok, bundle);
}
catch (Exception ex)
{
bundle.PutString("error", ex.ToString());
Finish(Result.Canceled, bundle);
}
});
bundle.PutInt("passed", consumer.Passed);
bundle.PutInt("failed", consumer.Failed);
bundle.PutInt("skipped", consumer.Skipped);
bundle.PutString("resultsPath", consumer.TrxReportPath);
Finish(Result.Ok, bundle);
}
catch (Exception ex)
{
bundle.PutString("error", ex.ToString());
Finish(Result.Canceled, bundle);
}
}

class ResultConsumer(Instrumentation instrumentation) : IDataConsumer
Expand Down