Skip to content

[release/10.0.1xx] Exclude NUnitLite from PoliCheck - #12393

Open
jonathanpeppers wants to merge 1 commit into
release/10.0.1xxfrom
jonathanpeppers-fix-english-policheck
Open

[release/10.0.1xx] Exclude NUnitLite from PoliCheck#12393
jonathanpeppers wants to merge 1 commit into
release/10.0.1xxfrom
jonathanpeppers-fix-english-policheck

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Description

Exclude the imported NUnitLite source folder from PoliCheck terminology scanning.

PoliCheck 7.1.2026071301 began reporting three longstanding Xbox references in NUnitLite's OSPlatform.cs and PlatformHelper.cs. These are third-party API identifiers and compatibility strings imported in 2016, not terms introduced by the triggering PR, so changing the vendor sources would be incorrect.

Validation

  • Parsed PoliCheck.Exclusions.xml successfully
  • Confirmed all three reported paths match the FolderPathFull exclusion
  • Ran git diff --check

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings August 14, 2026 19:45
@jonathanpeppers

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates PoliCheck terminology scanning configuration to exclude the imported third-party NUnitLite source folder, avoiding false-positive terminology findings on longstanding upstream API identifiers/compatibility strings.

Changes:

  • Added NUNITLITE to the FolderPathFull exclusion list in PoliCheck.Exclusions.xml so PoliCheck skips paths containing the NUnitLite folder segment.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@jonathanpeppers

Copy link
Copy Markdown
Member Author
image

@jonathanpeppers jonathanpeppers added the ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable). label Aug 15, 2026
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exclusion is narrowly scoped to the imported NUnitLite folder, covers the reported third-party identifiers, and the PoliCheck stage now passes. The remaining CI failure is unrelated workload-pack extraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants