Repository navigation
[build] Remove the remaining external/Java.Interop layout - #13393
Merged
jonathanpeppers merged 1 commit intoNov 5, 2026
Merged
Conversation
Context: #13378 #13378 moved the Java.Interop projects into the standard source and test directories, but left 23 documentation, legal, localization, and configuration files under external/Java.Interop. The old directory therefore remained in main after the project migration. Move the documentation and legal files to Documentation/Java.Interop and the generated localization files to the root Localize/loc tree. Update the localization mapping and documentation references, and remove the obsolete nested Git configuration so the old directory can disappear entirely. Preserve all translation and legal-file contents unchanged. Validate all 13 localization moves byte-for-byte, parse their XML, resolve the updated localization mapping and all 15 relative documentation links, and confirm the old directory and references are absent. Whitespace checks pass with the existing JSON CRLF line endings accounted for. No SDK compilation or runtime tests are needed for this documentation and localization-path cleanup. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the Java.Interop supporting-file relocation.
No open issues 🎉
What changed in this PR
Completes the Java.Interop layout migration started in #13378 by relocating the remaining supporting files and removing obsolete nested Git configuration. No implementation or project files change.
Changes:
- Move Java.Interop documentation and legal files into
Documentation/Java.Interop/, updating links and repository guidance. - Relocate generated localization files into the root
Localize/loc/tree and update their mapping, preserving translation contents. - Remove the remaining nested
.gitignoreand.gitattributes.
| File | Description |
|---|---|
Localize/LocProject.json |
Points localization mapping to the root tree. |
Localize/loc/zh-Hant/src/Java.Interop.Localization/Resources.resx.lcl |
Relocates Traditional Chinese translations unchanged. |
Localize/loc/zh-Hans/src/Java.Interop.Localization/Resources.resx.lcl |
Relocates Simplified Chinese translations unchanged. |
Localize/loc/tr/src/Java.Interop.Localization/Resources.resx.lcl |
Relocates Turkish translations unchanged. |
Localize/loc/ru/src/Java.Interop.Localization/Resources.resx.lcl |
Relocates Russian translations unchanged. |
Localize/loc/pt-BR/src/Java.Interop.Localization/Resources.resx.lcl |
Relocates Brazilian Portuguese translations unchanged. |
Localize/loc/fr/src/Java.Interop.Localization/Resources.resx.lcl |
Relocates French translations unchanged. |
Localize/loc/es/src/Java.Interop.Localization/Resources.resx.lcl |
Relocates Spanish translations unchanged. |
external/Java.Interop/.gitignore |
Removes obsolete nested ignore rules. |
external/Java.Interop/.gitattributes |
Removes obsolete nested Git attributes. |
Documentation/README.md |
Adds the Java.Interop documentation entry. |
Documentation/Java.Interop/ThirdPartyNotices.txt |
Relocates third-party notices unchanged. |
Documentation/Java.Interop/README.md |
Updates links for the relocated overview. |
Documentation/Java.Interop/Motivation.md |
Relocates the project motivation document. |
Documentation/Java.Interop/LICENSE |
Relocates the license unchanged. |
Documentation/Java.Interop/JNI-Invocation-Overhead-Musings.md |
Links historical performance tests to a pinned upstream revision. |
Documentation/Java.Interop/EnumMappingFile.md |
Relocates enumeration mapping documentation. |
Documentation/Java.Interop/BuildConfiguration.md |
Adjusts build and source links for the new location. |
Documentation/Java.Interop/Architecture.md |
Adjusts interoperability and migration-note links. |
.github/skills/update-tpn/SKILL.md |
Updates Java.Interop source and legal-file locations. |
.github/instructions/java-interop.instructions.md |
Updates documentation references in repository guidance. |
Review effort: Balanced
jonathanpeppers
approved these changes
Nov 5, 2026
jonathanpeppers
deleted the
simonrozsival-java-interop-layout-investigation
branch
November 5, 2026 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #13378
#13378 moved the Java.Interop projects into the standard source and test directories, but left 23 documentation, legal, localization, and configuration files under
external/Java.Interop. The old directory therefore remained inmainafter the project migration.Move documentation and legal files to
Documentation/Java.Interop/and the generated localization files to the rootLocalize/loc/tree. Update the localization mapping, documentation links, and repository guidance, and remove the obsolete nested Git configuration. Translation and legal-file contents remain unchanged;external/Java.Interopis completely removed.Validation
test ! -e external/Java.Interop— passed.git -c core.whitespace=cr-at-eol diff HEAD --checkandgit -c core.whitespace=cr-at-eol diff --cached --check— passed, preserving the existing JSON CRLF line endings.SDK compilation and runtime tests were not run because this changes only documentation, localization paths, and obsolete Git configuration; no implementation or project files changed.