Skip to content

Teach compiler driver to ignore unknown warning codes - #20246

Merged
T-Gro merged 3 commits into
mainfrom
copilot/fsc-ignore-unrecognized-diagnostics
Aug 13, 2026
Merged

Teach compiler driver to ignore unknown warning codes#20246
T-Gro merged 3 commits into
mainfrom
copilot/fsc-ignore-unrecognized-diagnostics

Conversation

Copilot AI commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Locate compiler option parsing and existing regression-test coverage
  • Ignore unrecognized diagnostic identifiers without changing known-code behavior
  • Add focused compiler-driver regression coverage
  • Run final release validation and review the committed diff

Copilot AI linked an issue Aug 11, 2026 that may be closed by this pull request
FSC should ignore error diagnostic identifiers that it does not understand. #3207
Closed
@baronfel
Ignore unknown warning diagnostic identifiers
25eb4d7 
Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com>
Copilot stopped work on behalf of baronfel due to an error August 11, 2026 19:14
Copilot had to stop work due to a timeout.
Copilot AI requested a review from baronfel August 11, 2026 19:14
@baronfel
baronfel marked this pull request as ready for review August 11, 2026 20:26
@baronfel
baronfel requested a review from a team as a code owner August 11, 2026 20:26
@github-actions

github-actions Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

❗ Release notes required

You can open this PR in browser to add release notes: open in github.dev

✅ Found changes and release notes in following paths:

Change path Release notes path Description
`src/Compiler` docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

@github-actions github-actions Bot added the AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed label Aug 11, 2026
@baronfel
Add release note for warning code handling
4c967be 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9af3efc7-f1b8-4b81-b7be-9e3352348190
@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Aug 12, 2026
@baronfel baronfel changed the title [WIP] Teach compiler driver to ignore unknown warning codes Teach compiler driver to ignore unknown warning codes Aug 12, 2026
@baronfel

baronfel commented Aug 13, 2026

Copy link
Copy Markdown
Member

@T-Gro anything else you need from me here? Otherwise I'm happy to see this merged :)

@T-Gro
T-Gro merged commit 0640920 into main Aug 13, 2026
55 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in F# Compiler and Tooling Aug 13, 2026
@T-Gro
T-Gro deleted the copilot/fsc-ignore-unrecognized-diagnostics branch August 13, 2026 15:37
@T-Gro

T-Gro commented Aug 13, 2026

Copy link
Copy Markdown
Member

All good 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes
@baronfel baronfel Awaiting requested review from baronfel

Assignees

@baronfel baronfel

Copilot code review Copilot

Labels

AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FSC should ignore error diagnostic identifiers that it does not understand.

3 participants

@baronfel @T-Gro