IL: share ILCallingConv instances - #20254
Open
auduchinok wants to merge 6 commits into
Open
Conversation
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
auduchinok
force-pushed
the
il-callingConv
branch
from
August 13, 2026 11:04
1c1b4ab to
cd07753
Compare
There are only 18 combinations of ILThisConvention and ILArgConvention. Pre-create all of them and hand out the shared instance from ILCallingConv.Create, so reading a method signature no longer allocates a Callconv. The two existing statics (Instance, Static) are placed in the table too, so every use shares one instance per combination. The index is computed with explicit matches rather than by casting the union tags, so adding a case to either union is a compile error here instead of a bad index. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
auduchinok
force-pushed
the
il-callingConv
branch
from
August 13, 2026 11:28
3bf3808 to
eeff5f0
Compare
github-actions
Bot
added
the
AI-Tooling-Check-Scanned-Clean
github-actions
Bot
added
the
⚠️ Affects-Compiler-Output
Contributor
|
🔍 Tooling Safety Check — Affects-Compiler-Output
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
ILCallingConv.Create, backed by a table of all 18 combinations, and uses it from the reader.In a heap snapshot of
ParseAndCheckProjectover a 57-file project with 489 references,ILCallingConvwent from 60,239 live objects (1.84 MB) to 18.Retained memory after ParseAndCheckProject: