Skip to content

[LoongArch64] Fix some new failures in Release libs.tests after PR#128604. - #132260

Open
LuckyXu-HF wants to merge 1 commit into
dotnet:mainfrom
LuckyXu-HF:main-LA64-1
Open

[LoongArch64] Fix some new failures in Release libs.tests after PR#128604.#132260
LuckyXu-HF wants to merge 1 commit into
dotnet:mainfrom
LuckyXu-HF:main-LA64-1

Conversation

@LuckyXu-HF

Copy link
Copy Markdown
Contributor
  • Fix the conflict of dstReg and tempReg for unchecked float/double -> small integral type conversions after PR#128604.
  • Fix the disassembly print of function name under release mode.

…8604.

* Fix the conflict of dstReg and tempReg for unchecked float/double -> small integral type conversions after PR#128604.
* Fix the disassembly print of function name under release mode.
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 13, 2026
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Aug 13, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@LuckyXu-HF

Copy link
Copy Markdown
Contributor Author

This commit fixes some new failures under Release libs.tests after PR#128604 , e.g. System.Linq.Expressions.Tests and System.Data.Common.Tests:

System.Linq.Expressions.Tests failures
  Discovering: System.Linq.Expressions.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Linq.Expressions.Tests (found 5668 of 5675 test cases)
  Starting:    System.Linq.Expressions.Tests (parallel test collections = on [8 threads], stop on fail = off)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableSByteTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 127
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11436,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToNullableSByte(Single value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(3077,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableSByteTest(Boolean useInterpreter)
        /home/xuliangyu/runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.CoreCLR.cs(37,0): at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(174,0): at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableSByteTest(useInterpreter: True) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 127
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11436,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToNullableSByte(Single value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(3077,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableSByteTest(Boolean useInterpreter)
           at InvokeStub_ConvertTests.ConvertFloatToNullableSByteTest(Object, Span`1)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(95,0): at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableByteTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 255
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9290,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyDoubleToNullableByte(Double value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1475,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableByteTest(Boolean useInterpreter)
        /home/xuliangyu/runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.CoreCLR.cs(37,0): at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(174,0): at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
    System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableByteTest(useInterpreter: True) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 255
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9290,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyDoubleToNullableByte(Double value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1475,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableByteTest(Boolean useInterpreter)
           at InvokeStub_ConvertTests.ConvertDoubleToNullableByteTest(Object, Span`1)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(95,0): at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableSByteTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 127
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9510,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyDoubleToNullableSByte(Double value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1637,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableSByteTest(Boolean useInterpreter)
        /home/xuliangyu/runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.CoreCLR.cs(37,0): at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(174,0): at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
    System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableSByteTest(useInterpreter: True) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 127
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9510,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyDoubleToNullableSByte(Double value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1637,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableSByteTest(Boolean useInterpreter)
           at InvokeStub_ConvertTests.ConvertDoubleToNullableSByteTest(Object, Span`1)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(95,0): at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableUShortTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 65535
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9598,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyDoubleToNullableUShort(Double value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1709,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableUShortTest(Boolean useInterpreter)
        /home/xuliangyu/runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.CoreCLR.cs(37,0): at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(174,0): at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
    System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableUShortTest(useInterpreter: True) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 65535
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9598,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyDoubleToNullableUShort(Double value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1709,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableUShortTest(Boolean useInterpreter)
           at InvokeStub_ConvertTests.ConvertDoubleToNullableUShortTest(Object, Span`1)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(95,0): at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableUShortTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 65535
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11524,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToNullableUShort(Single value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(3149,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableUShortTest(Boolean useInterpreter)
        /home/xuliangyu/runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.CoreCLR.cs(37,0): at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(174,0): at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableUShortTest(useInterpreter: True) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 65535
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11524,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToNullableUShort(Single value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(3149,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableUShortTest(Boolean useInterpreter)
           at InvokeStub_ConvertTests.ConvertFloatToNullableUShortTest(Object, Span`1)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(95,0): at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableCharTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 0xffff
      Actual:   '\0'
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11238,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToNullableChar(Single value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(2933,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableCharTest(Boolean useInterpreter)
        /home/xuliangyu/runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.CoreCLR.cs(37,0): at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(174,0): at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableCharTest(useInterpreter: True) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 0xffff
      Actual:   '\0'
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11238,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToNullableChar(Single value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(2933,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableCharTest(Boolean useInterpreter)
           at InvokeStub_ConvertTests.ConvertFloatToNullableCharTest(Object, Span`1)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(95,0): at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableByteTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 255
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11216,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToNullableByte(Single value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(2915,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableByteTest(Boolean useInterpreter)
        /home/xuliangyu/runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.CoreCLR.cs(37,0): at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(174,0): at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableByteTest(useInterpreter: True) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 255
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11216,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToNullableByte(Single value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(2915,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableByteTest(Boolean useInterpreter)
           at InvokeStub_ConvertTests.ConvertFloatToNullableByteTest(Object, Span`1)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(95,0): at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableShortTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 32767
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11458,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToNullableShort(Single value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(3095,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableShortTest(Boolean useInterpreter)
        /home/xuliangyu/runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.CoreCLR.cs(37,0): at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(174,0): at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
    System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableShortTest(useInterpreter: True) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 32767
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(11458,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyFloatToNullableShort(Single value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(3095,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertFloatToNullableShortTest(Boolean useInterpreter)
           at InvokeStub_ConvertTests.ConvertFloatToNullableShortTest(Object, Span`1)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(95,0): at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableShortTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 32767
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9532,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyDoubleToNullableShort(Double value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1655,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableShortTest(Boolean useInterpreter)
        /home/xuliangyu/runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.CoreCLR.cs(37,0): at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(174,0): at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
    System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableShortTest(useInterpreter: True) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 32767
      Actual:   0
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9532,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyDoubleToNullableShort(Double value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1655,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableShortTest(Boolean useInterpreter)
           at InvokeStub_ConvertTests.ConvertDoubleToNullableShortTest(Object, Span`1)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(95,0): at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableCharTest(useInterpreter: False) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 0xffff
      Actual:   '\0'
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9312,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyDoubleToNullableChar(Double value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1493,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableCharTest(Boolean useInterpreter)
        /home/xuliangyu/runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.CoreCLR.cs(37,0): at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(174,0): at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
    System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableCharTest(useInterpreter: True) [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 0xffff
      Actual:   '\0'
      Stack Trace:
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(9312,0): at System.Linq.Expressions.Tests.ConvertTests.VerifyDoubleToNullableChar(Double value, Boolean useInterpreter)
        /home/xuliangyu/runtime/src/libraries/System.Linq.Expressions/tests/Convert/ConvertTests.cs(1493,0): at System.Linq.Expressions.Tests.ConvertTests.ConvertDoubleToNullableCharTest(Boolean useInterpreter)
           at InvokeStub_ConvertTests.ConvertDoubleToNullableCharTest(Object, Span`1)
        /home/xuliangyu/runtime/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.cs(95,0): at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
  Finished:    System.Linq.Expressions.Tests
=== TEST EXECUTION SUMMARY ===
   System.Linq.Expressions.Tests  Total: 35118, Errors: 0, Failed: 20, Skipped: 0, Time: 21.648s
System.Data.Common.Tests failures
  Discovering: System.Data.Common.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Data.Common.Tests (found 1829 of 1831 test cases)
  Starting:    System.Data.Common.Tests (parallel test collections = on [8 threads], stop on fail = off)
    System.Data.Tests.SqlTypes.SqlSingleTest.Conversions [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 250
      Actual:   32767
      Stack Trace:
        /data/xuliangyu/runtime/src/libraries/System.Data.Common/tests/System/Data/SqlTypes/SqlSingleTest.cs(248,0): at System.Data.Tests.SqlTypes.SqlSingleTest.Conversions()
           at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
           at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
           at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
           at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
    System.Data.Tests.SqlTypes.SqlDoubleTest.Conversions [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 250
      Actual:   32767
      Stack Trace:
        /data/xuliangyu/runtime/src/libraries/System.Data.Common/tests/System/Data/SqlTypes/SqlDoubleTest.cs(240,0): at System.Data.Tests.SqlTypes.SqlDoubleTest.Conversions()
           at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
           at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
           at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
           at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
    System.Data.SqlTypes.Tests.SqlStringSortingTest.SqlStringValidComparisonTest(cultureName: "ja-JP", localeId: 1041) [SKIP]
      PlatformDetection.IsIcuGlobalization and cultureName == ja-JP
    System.Data.Tests.SqlTypes.SqlInt16Test.SqlSingleToSqlInt16 [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 64
      Actual:   32767
      Stack Trace:
        /data/xuliangyu/runtime/src/libraries/System.Data.Common/tests/System/Data/SqlTypes/SqlInt16Test.cs(548,0): at System.Data.Tests.SqlTypes.SqlInt16Test.SqlSingleToSqlInt16()
           at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
           at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
           at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
           at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
    System.Data.Tests.SqlTypes.SqlInt16Test.SqlDoubleToSqlInt16 [FAIL]
      Assert.Equal() Failure: Values differ
      Expected: 64
      Actual:   32767
      Stack Trace:
        /data/xuliangyu/runtime/src/libraries/System.Data.Common/tests/System/Data/SqlTypes/SqlInt16Test.cs(495,0): at System.Data.Tests.SqlTypes.SqlInt16Test.SqlDoubleToSqlInt16()
           at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
           at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
           at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
           at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
  Finished:    System.Data.Common.Tests
=== TEST EXECUTION SUMMARY ===
   System.Data.Common.Tests  Total: 11734, Errors: 0, Failed: 4, Skipped: 1, Time: 15.001s

Fixed:

  Discovering: System.Linq.Expressions.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Linq.Expressions.Tests (found 5668 of 5675 test cases)
  Starting:    System.Linq.Expressions.Tests (parallel test collections = on [8 threads], stop on fail = off)
  Finished:    System.Linq.Expressions.Tests
=== TEST EXECUTION SUMMARY ===
   System.Linq.Expressions.Tests  Total: 35118, Errors: 0, Failed: 0, Skipped: 0, Time: 33.862s

  Discovering: System.Data.Common.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Data.Common.Tests (found 1829 of 1831 test cases)
  Starting:    System.Data.Common.Tests (parallel test collections = on [8 threads], stop on fail = off)
    System.Data.SqlTypes.Tests.SqlStringSortingTest.SqlStringValidComparisonTest(cultureName: "ja-JP", localeId: 1041) [SKIP]
      PlatformDetection.IsIcuGlobalization and cultureName == ja-JP
  Finished:    System.Data.Common.Tests
=== TEST EXECUTION SUMMARY ===
   System.Data.Common.Tests  Total: 11734, Errors: 0, Failed: 0, Skipped: 1, Time: 7.424s

@LuckyXu-HF

Copy link
Copy Markdown
Contributor Author

@shushanhf @jakobbotsch Could you please help to review this PR? Thanks.

@shushanhf shushanhf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late reply.
LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants