Skip to content

Sync shared code from aspnetcore - #132273

Merged
MihaZupan merged 2 commits into
mainfrom
github-action/sync-aspnetcore-1786624044
Aug 14, 2026
Merged

Sync shared code from aspnetcore#132273
MihaZupan merged 2 commits into
mainfrom
github-action/sync-aspnetcore-1786624044

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

This PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943

Port of dotnet/aspnetcore#68321 to runtime

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@MihaZupan MihaZupan added this to the 11.0.0 milestone Aug 13, 2026
@MihaZupan MihaZupan self-assigned this Aug 13, 2026
@MihaZupan

Copy link
Copy Markdown
Member

@copilot Fix the build

Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>

Copilot AI commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@copilot Fix the build

Fixed in 8a5f7ca.

The break was error CS0117: 'SR' does not contain a definition for 'net_http_qpack_invalid_index' — the sync added the string to the aspnetcore-mirrored Common/src/System/Net/Http/aspnetcore/SR.resx, but System.Net.Http generates its SR from src/libraries/System.Net.Http/src/Resources/Strings.resx, which needed the entry added manually (with runtime-appropriate wording, matching how net_http_qpack_no_dynamic_table differs between the two files).

Verified: ./build.sh clr+libs -c Release succeeded (0 errors), and System.Net.Http.Unit.Tests ran 2681 tests with 0 failures, including the new DecodesIndexOutsideStaticTable_Error theory.

Copilot AI requested a review from MihaZupan August 13, 2026 18:45
@MihaZupan
MihaZupan requested a review from a team August 14, 2026 09:43
@MihaZupan
MihaZupan enabled auto-merge (squash) August 14, 2026 11:00
@MihaZupan
MihaZupan merged commit 00e092e into main Aug 14, 2026
78 checks passed
@MihaZupan
MihaZupan deleted the github-action/sync-aspnetcore-1786624044 branch August 14, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The runtime<->aspnetcore shared src is out of sync

3 participants