Skip to content

Extend ERROR_NO_ASSOCIATION with descriptive error messages #132292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 4 commits into from
Aug 14, 2026
+8 −2
Merged

Extend ERROR_NO_ASSOCIATION with descriptive error messages #132292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97ee087
Replace Win32Exception(ERROR_NO_ASSOCIATION) with exceptions with cle…
Copilot Aug 13, 2026
329f035
Preserve ERROR_NO_ASSOCIATION NativeErrorCode and clarify resource st…
Copilot Aug 13, 2026
28270ca
Clarify Unix UseShellExecute no-opener error text
Copilot Aug 13, 2026
8e1b1ea
Update Strings.resx
adamsitnik Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ private static SafeProcessHandle StartWithShellExecute(ProcessStartInfo startInf
if (verb != string.Empty &&
!string.Equals(verb, "open", StringComparison.OrdinalIgnoreCase))
{
throw new Win32Exception(Interop.Errors.ERROR_NO_ASSOCIATION);
throw new Win32Exception(Interop.Errors.ERROR_NO_ASSOCIATION, SR.Format(SR.UseShellExecuteVerbNotSupported, verb));
}

// On Windows, UseShellExecute of executables and scripts causes those files to be executed.
Expand Down Expand Up @@ -405,7 +405,7 @@ private static SafeProcessHandle StartWithShellExecute(ProcessStartInfo startInf
}

// use default program to open file/url
filename = Process.GetPathToOpenFile() ?? throw new Win32Exception(Interop.Errors.ERROR_NO_ASSOCIATION);
filename = Process.GetPathToOpenFile() ?? throw new Win32Exception(Interop.Errors.ERROR_NO_ASSOCIATION, SR.UseShellExecuteNoOpenProgram);
string[] openFileArgv = ProcessUtils.ParseArgv(startInfo, filename, ignoreArguments: true);

SafeProcessHandle result = ForkAndExecProcess(
Expand Down
6 changes: 6 additions & 0 deletions src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,4 +390,10 @@
<data name="Argument_InvalidProcessId" xml:space="preserve">
<value>The callback must return a positive process ID for the newly created process.</value>
</data>
<data name="UseShellExecuteVerbNotSupported" xml:space="preserve">
<value>The verb '{0}' is not supported for UseShellExecute on this platform. Only the default verb (an empty string or "open") is supported.</value>
</data>
<data name="UseShellExecuteNoOpenProgram" xml:space="preserve">
<value>No program was found to handle opening files or URLs with UseShellExecute on this platform. Ensure one such as 'xdg-open' or 'open' is installed and available on the PATH.</value>
</data>
</root>