Fix hang in SSL do_handshake and rework server shutdown routine #110
Open
uzlonewolf wants to merge 3 commits intodpallot:masterfrom
Open
Fix hang in SSL do_handshake and rework server shutdown routine #110uzlonewolf wants to merge 3 commits intodpallot:masterfrom
uzlonewolf wants to merge 3 commits intodpallot:masterfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having a problem with the server hanging and not accepting new connections. I tracked it down to connections which have been opened but then do not complete a SSL/TLS handshake. It can be reproduced by simply opening a TCP connection and then not sending anything; example python:
The server is now hung and no other connection can be opened.
Closes #13
I also reworked the server shutdown code so it actually sends the CLOSE command it queues up.
Closes #85