Updated deprecated sys.puts and added invalid ssl support#141
Open
greenmanspirit wants to merge 4 commits intodriverdan:masterfrom
Open
Updated deprecated sys.puts and added invalid ssl support#141greenmanspirit wants to merge 4 commits intodriverdan:masterfrom
greenmanspirit wants to merge 4 commits intodriverdan:masterfrom
Conversation
…tests to match the behavior set in the test-headers.js file
… to ignore an invalid certificate. This is so you can write apps to connect to self signed cert servers.
greenmanspirit
force-pushed
the
master
branch
from
df80728 to
70faa28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I first updated the tests to handle the deprecation warning that I received from node v4.2.6 for sys.puts.
I wanted to make it so that developers can write apps that can connect to self signed cert servers. I did this by adding an argument to open that allows the developer to set whether they want to reject invalid ssl certs. This is then used by send to send rejectUnauthorized to https.
I also wrote two new tests files to test this new behavior.