Repository navigation
Package only what FolderSync needs to run - #7
Merged
Merged
Conversation
The packager listed files to leave out, so files added later, like the lint configs and the token server source, ended up in app.asar. It now keeps only package.json, dist/, and build/icon.png.
joshyunho
marked this pull request as ready for review
October 30, 2026 14:00
pselden
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The packager listed the files to leave out of
app.asar, so files added later, like the lint configs and the token server's Go source, were packaged too. It now keeps onlypackage.json,dist/, andbuild/icon.png.Test plan
npm run package:app.asarholds onlypackage.json,build/icon.png, and the 51 files indist/, and the packaged app starts.