Rename column arg in relational API functions to exrpession#295
Merged
evertlammerts merged 1 commit intoduckdb:v1.5-variegatafrom Feb 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/duckdblabs/duckdb-internal/issues/7150
We rename from
columntoexpressionto make very clear that this string can take an arbitrary expression, and if people want to pass in user-supplied data then they are responsible for validating its content.This is technically a breaking change, because we're changing the name of an arg that is not a positional-only arg (
column). It's not a keyword-only arg either though, and it's not idiomatic to name non-keyword-only args in calls. A formal deprecation path is also likely to be messy. In this case, just a rename seems justified.