Skip to content

reorganized the code layout#74

Open
brahimgb wants to merge 1 commit intodzcode-io:developfrom
brahimgb:develop
Open

reorganized the code layout#74
brahimgb wants to merge 1 commit intodzcode-io:developfrom
brahimgb:develop

Conversation

@brahimgb
Copy link
Copy Markdown

Description

i have reorganized the code layout for the data file I have not edited nor changed the data

Fixes # (issue)

Type of change

reorganized

Please delete options that are not relevant.

  • Updated the dataset

Checklist:

  • I checked that there's no dataset update (can be done by running npm run update-dataset)
  • npm test passes on my machine
  • npm run lint passes on my machine

@ZibanPirate
Copy link
Copy Markdown
Member

hey @ibrahimgb thanks for the PR, is there a need or a reason for this change?

@ZibanPirate ZibanPirate added the enhancement New feature or request label Feb 13, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 13, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3fe8e06) to head (cf2c0e6).
⚠️ Report is 17 commits behind head on develop.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          173       173           
  Branches        33        33           
=========================================
  Hits           173       173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brahimgb
Copy link
Copy Markdown
Author

reason for this change: the hole data was crammed in one line. I just organize it to make it easy for future contributions (who want to update the dataset).

hey @ibrahimgb thanks for the PR, is there a need or a reason for this change?

@Fcmam5
Copy link
Copy Markdown
Collaborator

Fcmam5 commented Feb 27, 2022

Hi @ibrahimgb the idea was to pull the dataset from the files in https://github.com/Fcmam5/algeria-api which is now super outdated.
And the data in one-line here is meant to use a compressed version of the dataset for a tiny-ish performance gain.

Or, do you have any suggestions for doing this better? We can keep the prettified version of the dataset and only minified when building the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Addressing Feedback

Development

Successfully merging this pull request may close these issues.

4 participants