Skip to content

Comments

Add app-mastro#99

Merged
AlexanderKaran merged 2 commits intoe18e:mainfrom
mb21:mastro
Feb 18, 2026
Merged

Add app-mastro#99
AlexanderKaran merged 2 commits intoe18e:mainfrom
mb21:mastro

Conversation

@mb21
Copy link
Contributor

@mb21 mb21 commented Feb 11, 2026

Making a PR to see whether the CI runs the ssr benchmark for Mastro.

@AlexanderKaran AlexanderKaran self-requested a review February 11, 2026 08:31
@AlexanderKaran
Copy link
Collaborator

@mb21 woooo thanks for the PR.

A new framework is a big consideration for us as it adds more maintenance work. To make it easier to assess, can you onboard it to the install and build time stats first?

Ping me if you need help or the guide is not clear.

@mb21 mb21 changed the title Add Mastro Add app-astro Feb 11, 2026
@mb21 mb21 changed the title Add app-astro Add app-mastro Feb 12, 2026
@mb21 mb21 force-pushed the mastro branch 3 times, most recently from 3bfb275 to c050903 Compare February 13, 2026 10:58
@mb21 mb21 marked this pull request as ready for review February 13, 2026 11:12
@mb21 mb21 requested a review from 43081j as a code owner February 13, 2026 11:12
@mb21
Copy link
Contributor Author

mb21 commented Feb 13, 2026

@AlexanderKaran I made the ssr metric work as well, thanks for your help!

@AlexanderKaran
Copy link
Collaborator

@mb21 Thank you, will have a look and check it against the others

@AlexanderKaran
Copy link
Collaborator

AlexanderKaran commented Feb 16, 2026

@mb21 Sorry for the slow reply, been doing some large changes:

  • We have now disconnected starter and app packages from the workspace (your starter is already done on main)
  • There is now a web handler option, although most still have to use Node for now

If you can merge and fix up that would be great. Sorry for the mess around your issues and PRs, which made me see a few things that needed fixing. Feedback on the updated ReadMe is also welcome

@mb21 mb21 force-pushed the mastro branch 4 times, most recently from f2c58a5 to 59b3251 Compare February 16, 2026 20:22
@mb21
Copy link
Contributor Author

mb21 commented Feb 16, 2026

Thanks for your work! And being able to use Request/Response directly is awesome!

I rebased this PR and made the required changes.

@AlexanderKaran
Copy link
Collaborator

@mb21 Great I will get this merged tomorrow and ensure the stats run :)

@AlexanderKaran AlexanderKaran merged commit 8cf2e1f into e18e:main Feb 18, 2026
3 checks passed
@mb21 mb21 deleted the mastro branch February 18, 2026 10:31
@mb21
Copy link
Contributor Author

mb21 commented Feb 18, 2026

Awesome! Let me know if you run into anything else...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants