Skip to content

Clean Code for ui/org.eclipse.pde.bnd.ui#2191

Merged
HannesWell merged 2 commits intomasterfrom
clean-code/ui/org.eclipse.pde.bnd.ui
Feb 28, 2026
Merged

Clean Code for ui/org.eclipse.pde.bnd.ui#2191
HannesWell merged 2 commits intomasterfrom
clean-code/ui/org.eclipse.pde.bnd.ui

Conversation

@eclipse-pde-bot
Copy link
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@eclipse-pde-bot
Copy link
Contributor Author

eclipse-pde-bot commented Jan 20, 2026

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From f9e89bd09033798842477cd46e1b6c58e18d5b24 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Sat, 28 Feb 2026 17:17:00 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
index af6778525c..4e63839b00 100644
--- a/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: Generic UI components related to BND
 Bundle-SymbolicName: org.eclipse.pde.bnd.ui;singleton:=true
 Bundle-Vendor: Eclipse.org
-Bundle-Version: 1.2.500.qualifier
+Bundle-Version: 1.2.600.qualifier
 Bundle-Localization: plugin
 Export-Package: org.eclipse.pde.bnd.ui.autocomplete;version="1.0.0";x-friends:="org.eclipse.pde.ui",
  org.eclipse.pde.bnd.ui.plugins;x-internal:=true,
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Test Results

   798 files  ±0     798 suites  ±0   53m 22s ⏱️ - 3m 53s
 3 787 tests ±0   3 733 ✅ ±0   54 💤 ±0  0 ❌ ±0 
11 127 runs  ±0  10 964 ✅ ±0  163 💤 ±0  0 ❌ ±0 

Results for commit 5f938e2. ± Comparison against base commit a624b7e.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the clean-code/ui/org.eclipse.pde.bnd.ui branch from ce3759c to b0e2e2f Compare February 28, 2026 17:11
@HannesWell HannesWell force-pushed the clean-code/ui/org.eclipse.pde.bnd.ui branch from b0e2e2f to 6acf65f Compare February 28, 2026 17:11
@HannesWell HannesWell merged commit 3b3c1ca into master Feb 28, 2026
16 of 19 checks passed
@HannesWell HannesWell deleted the clean-code/ui/org.eclipse.pde.bnd.ui branch February 28, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants