Only set dialog.setOpenOnRun(false) according to preference #486#4124
Open
fedejeanne wants to merge 2 commits into
Open
Only set dialog.setOpenOnRun(false) according to preference #486#4124fedejeanne wants to merge 2 commits into
fedejeanne wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the workbench progress service decides whether to open a modal progress dialog when running “backward compatible” operations (ProgressManager#run branch for !fork || !cancelable). It aims to restore expected progress reporting behavior (Issue #4086) by only disabling automatic dialog opening (setOpenOnRun(false)) when the “Always run in background” preference indicates dialogs should not be shown.
Changes:
- Moves
dialog.setOpenOnRun(false)so it is applied only whenshouldRunInBackground()istrue. - Keeps the delayed “open progress dialog” scheduling path when dialogs are allowed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
fedejeanne
force-pushed
the
progress_monitor_run_in_background
branch
from
5639b51 to
4a2b85f
Compare
Same as with the other call in the same class, whoever schedules the progress dialog to be shown after a delay (800 ms) should also make sure that the dialog doesn't pop-up if the runnable is finished before the delay has elapsed.
fedejeanne
force-pushed
the
progress_monitor_run_in_background
branch
from
4a2b85f to
19773cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4086