-
Notifications
You must be signed in to change notification settings - Fork 95
chore: increase version numbers to 1.0.0 for next release #1466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: increase version numbers to 1.0.0 for next release #1466
Conversation
error TS2322: Type 'Buffer<ArrayBufferLike>' is not assignable to type 'ArrayBuffer'.
|
Mhh, on the CI we get CoAP issues Not sure what causes them.. locally I don't see them.. |
should report allproperties excluding non-JSON properties
|
@JKRhb I noticed an issue with a CoAP test (see "should report allproperties excluding non-JSON properties") Do you know what might be happening? Excluding the one test makes the CI happy again. So either we skip/change the test or set a fixed node coap version like 1.4.1. |
…test-name-typos refactor: fix spelling issues in test names
…r/thingweb.node-wot into danielpeintner-next-version-1-0-0
activate test again
|
FYI: I switched back to version coap 1.4.1 and created #1471 to keep track of the issue with coap v1.5 The only remaining part before merging the PR is whether we can get rid of 4096 check |
|
PR looks good now for me... but I cannot approve it myself ;-) |
FYI: As usual, every time we update the node-wot package versions, we also newly create
package-lock.jsonto update dependencies.Hence, one can see many changes for
package-lock.json...NOTE: please take a look at the changes in
interaction-output.tsWithout any changes we get
error TS2322: Type 'Buffer<ArrayBufferLike>' is not assignable to type 'ArrayBuffer'.The reason is that buffer (specifically
Buffer<ArrayBufferLike>) is no longer directly compatible with ArrayBuffer.There are at least 2 possible fixes.. the one I used is forcing type conversion
The alternative would be wrapping the buffer in a Uint8Array ... causes a test to fail, but that could be fixed.
Opinions?