Conversation
Fixes eclipse-threadx#67 The NAND application API calls page-sized logical units sectors, which can be confused with FileX sectors. Add page and pages names for read, write, and release. Keep sector names as aliases to the same symbols, and name public parameters logical_page and page_count. GCC 14.3 NAND regression passed (1/1). The test exercised all six page names, and existing sector calls compiled. Assisted-by: Codex (GPT-6-Sol) <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
The NAND application API calls page-sized logical units sectors, which can be confused with FileX sectors.
Add page and pages names for read, write, and release. Keep sector names as aliases to the same symbols, and name public parameters
logical_pageandpage_count. @rahmanih, please review this approach. I’m willing to do it differently if you disagree.GCC 14.3 NAND regression passed (1/1). The test exercised all six page names, and existing sector calls compiled.