Skip to content

Stopped zero-length ISO packets stranding audio frame slots #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fdesbiens merged 2 commits into from
Oct 1, 2026
Merged

Stopped zero-length ISO packets stranding audio frame slots #271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
851bf70
fix: skip zero-length ISO OUT packets in audio read thread
Nictrla Jul 27, 2026
72b6b39
Brought the zero-length skip into the surrounding style
fdesbiens Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions common/usbx_device_classes/src/ux_device_class_audio_read_thread_entry.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,14 @@ ULONG actual_length;
/* Get actual transfer length. */
actual_length = transfer -> ux_slave_transfer_request_actual_length;

/* A zero length packet carries no audio. Logging it would leave a
frame whose length is zero, which is what marks a slot free, and
the transfer position would still advance past it. */
if (actual_length == 0)
{
continue;
}

/* Frame received, log it. */
stream -> ux_device_class_audio_stream_transfer_pos -> ux_device_class_audio_frame_length = actual_length;
stream -> ux_device_class_audio_stream_transfer_pos -> ux_device_class_audio_frame_pos = 0;
Expand Down