Remove code duplication in GridData2 #964#1381
Draft
ptziegler wants to merge 1 commit intoeclipse-windowbuilder:masterfrom
Draft
Remove code duplication in GridData2 #964#1381ptziegler wants to merge 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler wants to merge 1 commit intoeclipse-windowbuilder:masterfrom
Conversation
Rather than copying the fields of the SWT `GridData`, the `GridData2` now stores a reference of the original `GridData` object. Using a copy of the original class brings the risk of incompatibilities, if the class is ever updated on the SWT side. So its only purpose should be to cache the bounds for the grid cell and delegate all other task to the base class. Contributes to eclipse-windowbuilder#964
Test Results 2 720 files ±0 2 720 suites ±0 12h 55m 22s ⏱️ + 10m 56s For more details on these errors, see this check. Results for commit c3ff1b4. ± Comparison against base commit 11c9cfb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than copying the fields of the SWT
GridData, theGridData2now stores a reference of the originalGridDataobject.Using a copy of the original class brings the risk of incompatibilities, if the class is ever updated on the SWT side. So its only purpose should be to cache the bounds for the grid cell and delegate all other task to the base class.
Contributes to
#964