ParamID strict behavior

[danovaro]

Description

METK-161 added optional parameter to ParamID::normalise to request strict behavior

Contributor Declaration

By opening this pull request, I affirm the following:

• All authors agree to the Contributor License Agreement.
• The code follows the project's coding standards.
• I have performed self-review and added comments where needed.
• I have added or updated tests to verify that my changes are effective and functional.
• I have run all existing tests and confirmed they pass.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 99.47090% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.42%. Comparing base (250f0da) to head (067b6ab).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/metkit/mars/ParamID.h	98.61%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #175      +/-   ##
===========================================
+ Coverage    61.02%   61.42%   +0.40%     
===========================================
  Files          309      309              
  Lines        11732    11723       -9     
  Branches      1035     1019      -16     
===========================================
+ Hits          7159     7201      +42     
+ Misses        4573     4522      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR extends metkit::ParamID::normalise() with an additional optional boolean parameter, allowing callers to explicitly select an alternate normalisation path (previously only enabled via the useGRIBParamID resource).

Changes:

• Adds a new optional parameter to ParamID::normalise()’s signature.
• Switches the normalisation branch condition to useGRIBParamID || useParamId to allow explicit caller override.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new boolean parameter useParamId doesn’t match the PR description (“strict behavior”) and is also ambiguous vs the existing useGRIBParamID resource. Consider renaming this parameter to reflect the behavioral intent (e.g., strict/strictNormalisation or forceGRIBParamID) and documenting what behavior changes when it is enabled.

[Copilot]

useParamId forces the useGRIBParamID branch (if (useGRIBParamID || useParamId)), but the debug logging inside this branch still labels the mode as useGRIBParamID. If this flag is intended for callers to request a different/stricter behavior, the logging (and possibly the condition naming) should be updated so diagnostics clearly reflect which mode is active.

[Copilot]

This change introduces a new normalization mode controllable via useParamId, but there are existing unit tests for ParamID::normalise (e.g., tests/test_param_axis.cc) and none currently exercise the new flag. Please add/extend tests to cover the behavior when useParamId=true (especially when the useGRIBParamID resource is false) to prevent regressions.