ci: split docker smoke, fix mypy, update azure docs and dedupe aliases - #38
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThe change expands LyraShield environment compatibility, updates Azure provider guidance and capability checks, and strengthens CI verification for the worker contract and sandbox container. ChangesRuntime configuration and provider compatibility
CI and sandbox validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lyrashield_adapter/cli.py`:
- Around line 58-69: Extend _STALE_EMPTY_ENV_VARS in lyrashield_adapter/cli.py
to include DEDUPE_LLM_API_KEY and DEDUPE_LLM_API_BASE so blank generic aliases
are purged before resolution. In strix/config/settings.py, update
DedupeSettings.api_key and api_base to use the existing empty-string-to-None
field validator pattern from LlmSettings._empty_env_to_none, covering callers
that bypass prepare_environment.
In `@strix/core/runner.py`:
- Around line 469-530: Update the ModelBehaviorError fallback in the root-agent
execution flow to rebuild run_config after creating the implicit-cache
model_settings and root_agent, so the retry uses the fallback configuration
rather than the original explicit prompt-cache settings. In the same fallback,
preserve resumed scan state by setting initial_input to [] when is_resume is
true, while continuing to build a new root task for non-resumed scans.
In `@strix/interface/main.py`:
- Around line 1102-1109: The dotenv loading paths use override=True despite
documenting that explicit shell exports take precedence. Update load_dotenv in
strix/interface/main.py lines 1102-1109 and the corresponding loading call in
lyrashield_adapter/cli.py lines 109-111 to use override=False, preserving the
documented precedence contract.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 3bea81a3-cea9-4d56-b710-183f53e887b0
📒 Files selected for processing (9)
.github/workflows/ci.ymldocs/llm-providers/azure.mdxlyrashield_adapter/cli.pystrix/config/models.pystrix/config/settings.pystrix/core/inputs.pystrix/core/runner.pystrix/interface/main.pytests/test_inputs.py
9faf8b4 to
697d42f
Compare
docker-smokeCI job with a 120-minute timeout andNET_ADMIN/NET_RAWcapability checks.docs/llm-providers/azure.mdxwith the preferredazure_ai/model prefix and a fullLYRASHIELD_*alias table.LYRASHIELD_*aliases for dedupe settings andprogrammatic_tool_calling/server_conversationproduct env vars.lyrashield_adapter/cli.pyandstrix/core/inputs.pysoverify-thin-fork.shpasses cleanly.Verification:
uv run ruff check strix lyrashield_adapter tests— passeduv run ruff format --check strix lyrashield_adapter tests— passeduv run mypy --exclude 'strix/interface/tui' strix lyrashield_adapter— passeduv run pytest -q— 593 passedSummary by CodeRabbit
Documentation
Configuration
Chores