feat(ampcc): separate out amp registry. add dataset details widget #1617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiyasmohd
requested changes
Jan 27, 2026
Contributor
shiyasmohd
left a comment
shiyasmohd
left a comment
There was a problem hiding this comment.
Please check my comments.
cmwhited
force-pushed
the
chris.whited/ampcc/feat-amp-registry-client
branch
from
7a1fb8b to
d102c0c
Compare
shiyasmohd
requested changes
Jan 28, 2026
Contributor
shiyasmohd
left a comment
shiyasmohd
left a comment
There was a problem hiding this comment.
Please check my comments
- We should add docs for all structs and each fields. this helps readability for us and LLMs
- As a rule of thumb, traits for structs only need to be implemented if it's used.
Debugis okay to add even if not used, but for structs which would help debugging.
Contributor
There was a problem hiding this comment.
Docs missing for structs and fields
shiyasmohd
reviewed
Jan 28, 2026
shiyasmohd
reviewed
Jan 28, 2026
cmwhited
force-pushed
the
chris.whited/ampcc/feat-amp-registry-client
branch
from
d76ce6f to
e821f03
Compare
shiyasmohd
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved to a separated
AmpRegistryClientthat uses the data models from the amp registry. Also performs the actual search against the amp registry api/api/vX/datasets/searchendpoint which performs a full-text lookup against multiple weighted fields when searching.And added support to fetch the datasets belonging to the authenticated user, if they are logged in.
And added a dataset details widget.
CleanShot.2026-01-23.at.17.01.16.mp4