refactor(datasets-common): remove network field from Dataset trait #1650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the Dataset trait by removing the network field since raw datasets always have tables that carry network information. - Remove `network` field and `network()` method from Dataset trait and all implementations - Update dataset constructors across extractors to remove network parameter - Access network via tables in `dataset-store`, enforcing raw datasets have tables - Add `RawDatasetManifest` in `datasets-raw` requiring network field for parsing - Remove `MissingNetwork` error variants now that network is table-derived Signed-off-by: Lorenzo Delgado <[email protected]>
LNSD
force-pushed
the
lnsd/refactor-datasets-common-remove-network-field
branch
from
81c31eb to
6707fb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the Dataset trait by removing the network field since raw datasets always have tables that carry network information.
networkfield andnetwork()method from Dataset trait and all implementationsdataset-store, enforcing raw datasets have tablesRawDatasetManifestindatasets-rawrequiring network field for parsingMissingNetworkerror variants now that network is table-derived