karpenter: clarify createServiceAccount semantics in docs, schema, and runtime log#8720
Open
cheeseandcereal wants to merge 1 commit intomainfrom
Open
karpenter: clarify createServiceAccount semantics in docs, schema, and runtime log#8720cheeseandcereal wants to merge 1 commit intomainfrom
cheeseandcereal wants to merge 1 commit intomainfrom
Conversation
…d runtime log
The karpenter.createServiceAccount flag controls which component
creates the 'karpenter' service account (eksctl vs the Karpenter
Helm chart), not whether a service account is created. A SA always
ends up on the cluster either way. The previous docs ("create a
service account or not") and silent log output for the true case
made this confusing.
This change:
- Rewrites the CreateServiceAccount struct-field comment in
pkg/apis/eksctl.io/v1alpha5/types.go to describe the actual
behavior, and regenerates schema.json.
- Adds a dedicated 'createServiceAccount' subsection to
userdocs/src/usage/eksctl-karpenter.md explaining both modes.
- Adds Info-level log output at runtime so eksctl reports which
component will create the SA.
No behavior changes.
Contributor
|
Hello cheeseandcereal 👋 Thank you for opening a Pull Request in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The karpenter.createServiceAccount flag controls which component creates the 'karpenter' service account (eksctl vs the Karpenter Helm chart), not whether a service account is created. A SA always ends up on the cluster either way. The previous docs ("create a service account or not") and silent log output for the true case made this confusing
This change:
No behavior changes.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯