ModalSearch: revive modal search with HTMX-compatible navigation for Codex#2796
Merged
ModalSearch: revive modal search with HTMX-compatible navigation for Codex#2796
Conversation
…Codex Replace NavigationSearch with ModalSearch in the Codex header and landing page. Use two-phase HTMX close strategy: hide backdrop on htmx:beforeSend, then fully close on htmx:afterSwap to keep anchors in the DOM during the HTMX request/response/swap cycle. Wire up ask-ai:ask event for the "Ask AI Assistant" integration. Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Mpdreamz
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
htmx:beforeSend, full unmount onhtmx:afterSwap) to keep the anchors alive while HTMX readshx-select-oobNotes
ask-ai:askcustom event handler inuseAskAiFlyoutenables the modal's "Tell me more about {query}" button to open the AI assistant with a pre-filled questionmodal-search:openinstead of embedding the NavigationSearch component directlyRecording
cursorful-video-1772108671567.mp4
Made with Cursor