Skip to content

fix: execute INSERTs with fetch=false #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-christophe-oudar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: execute INSERTs with fetch=false #1049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39c8e64
fix: execute Elementary INSERTs with fetch=false so Fusion does not S…
Kayrnt Aug 24, 2026
e3c64f1
chore: describe execute_no_fetch as discard-result DML, not a warehou…
Kayrnt Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions macros/edr/tests/on_run_end/handle_tests_results.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@
{%- do elementary.edr_create_table_as(
true, temp_relation, test_tables_union_query
) %}
{% do elementary.run_query(insert_query) %}
{% do elementary.execute_no_fetch(insert_query) %}

{# DuckDB: commit so insert survives dbt's post-on-run-end ROLLBACK #}
{% if target.type == "duckdb" %} {% do adapter.commit() %} {% endif %}
Expand Down Expand Up @@ -280,7 +280,7 @@
{%- do elementary.edr_create_table_as(
true, temp_relation, test_tables_union_query
) %}
{% do elementary.run_query(insert_query) %}
{% do elementary.execute_no_fetch(insert_query) %}

{# DuckDB: commit so insert survives dbt's post-on-run-end ROLLBACK #}
{% if target.type == "duckdb" %} {% do adapter.commit() %} {% endif %}
Expand Down
8 changes: 8 additions & 0 deletions macros/utils/run_queries/run_query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@
{% do return(query_result) %}
{% endmacro %}

{# Execute without fetching a result set. Use this for DML/DDL whose callers
discard the result; dbt.run_query always fetches. #}
{% macro execute_no_fetch(query) %}
{% do adapter.execute(
elementary.format_query_with_metadata(query), fetch=false
) %}
{% endmacro %}

{% macro format_query_with_metadata(query) %}
{% do return(
adapter.dispatch("format_query_with_metadata", "elementary")(query)
Expand Down
2 changes: 1 addition & 1 deletion macros/utils/table_operations/insert_rows.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"[{}/{}] Running insert query.".format(loop.index, queries_len)
) %}
{% do elementary.begin_duration_measure_context("run_insert_rows_query") %}
{% do elementary.run_query(insert_query) %}
{% do elementary.execute_no_fetch(insert_query) %}
{% do elementary.end_duration_measure_context("run_insert_rows_query") %}
{% endfor %}

Expand Down
Loading