Decode void type on CockroachDB - #791
Merged
Merged
Conversation
CockroachDB names the void type's send/output procs without underscores (voidsend / voidout), so the built-in VoidBinary/VoidText extensions never bind and `SELECT`s returning void (e.g. pg_advisory_xact_lock/1) raise `type "void" can not be handled`. Match CRDB's proc spelling in addition to Postgres' so void decodes on both engines. The wire format is identical; only the matching changes, and the Postgres path is unaffected.
milmazz
marked this pull request as ready for review
August 5, 2026 18:57
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CockroachDB names the void type's send/output procs without underscores (
voidsend/voidout), so the built-inVoidBinary/VoidTextextensions never bind andSELECTs returning void (e.g. pg_advisory_xact_lock/1) raisetype "void" can not be handled.Match CRDB's proc spelling in addition to Postgres' so void decodes on both engines. The wire format is identical; only the matching changes, and the Postgres path is unaffected.