Skip to content

Feature/metabolights - #56

Open
oyurekten wants to merge 30 commits into
mainfrom
feature/metabolights
Open

oyurekten wants to merge 30 commits into
mainfrom
feature/metabolights

Conversation

@oyurekten

Copy link
Copy Markdown
Collaborator

No description provided.

@oyurekten
oyurekten force-pushed the feature/metabolights branch from 42a338d to c4d865e Compare November 12, 2026 21:35

@kdp-cloud kdp-cloud left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some minor comments but I am fine with you looking at them later. I don't think it should be a blocker.
Once the tests all pass, we can merge.

- "tests/**"
- "pyproject.toml"
- "uv.lock"
- "mars_lib/**"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Formatting is off

from mars_lib.models.isa_json import Investigation
from mars_lib.models.repository_response import RepositoryResponse

logger = logging.getLogger(__name__)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if you could reuse the existing logging.

logger = logging.getLogger("MARS-CLI")

Comment thread .gitignore
*.py[cod]
*$py.class

tests/fixtures/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of the tests use the fixtures?
I don't think so.

Comment thread .pre-commit-config.yaml

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: Nice!

@kdp-cloud

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

oyurekten and others added 3 commits November 13, 2026 10:23
# Conflicts:
#	MARS

Co-authored-by: kdp-cloud <82407142+kdp-cloud@users.noreply.github.com>
…re/metabolights

Co-authored-by: kdp-cloud <82407142+kdp-cloud@users.noreply.github.com>

Copilot AI commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts and integrated the latest PR commits. The merge commit is 8312bcf (with the latest PR updates merged in ed0686b).

@bedroesb bedroesb linked an issue Nov 13, 2026 that may be closed by this pull request
5 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Perform an actual multi-omic submission

4 participants