Repository navigation
Use ENA's FILE attribute names for data-file comments; add PTX to the integration test - #57
Merged
Merged
Conversation
kdp-cloud
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows the MARS ENA adapter change in elixir-europe/MARS (fix-file): data-file comments are now named after the attributes of ENA's FILE element (
filename,filetype,checksum,checksum_method). Also adds the PTX dataset to the integration test.Changes
scripts/isa_generator.pywritesfilename,filetype,checksumandchecksum_method, and removes the older spellings (file name,file type,file checksum,checksum type, …). Before, it added the old names next to the new ones in the templates, so ENA would have received the template's file name and checksum instead of the generated file's.tests/fixtures/isa_jsons/1_after_biosamples.json: the same comments renamed.tests/test_isa_json.py: new path for the PTX JSON, which moved to the top level ofMARS/test-data/.prepare_poc_submission.pynow prepares any extra submission whose template variable is set (HOLOFOOD_ISA_TEMPLATE_PATH,PTX_ISA_TEMPLATE_PATH).MARSsubmodule bumped to the adapter changes.Depends on elixir-europe/MARS#192