Skip to content

Use ENA's FILE attribute names for data-file comments; add PTX to the integration test - #57

Merged
kdp-cloud merged 6 commits into
mainfrom
better-file-attrib
Nov 13, 2026
Merged

kdp-cloud merged 6 commits into
mainfrom
better-file-attrib

Conversation

@bedroesb

Copy link
Copy Markdown
Member

Summary

Follows the MARS ENA adapter change in elixir-europe/MARS (fix-file): data-file comments are now named after the attributes of ENA's FILE element (filename, filetype, checksum, checksum_method). Also adds the PTX dataset to the integration test.

Changes

  • scripts/isa_generator.py writes filename, filetype, checksum and checksum_method, and removes the older spellings (file name, file type, file checksum, checksum type, …). Before, it added the old names next to the new ones in the templates, so ENA would have received the template's file name and checksum instead of the generated file's.
  • tests/fixtures/isa_jsons/1_after_biosamples.json: the same comments renamed.
  • tests/test_isa_json.py: new path for the PTX JSON, which moved to the top level of MARS/test-data/.
  • Integration test: a new "Submit PTX ISA JSON" step (BioSamples + ENA, like HoloFood). prepare_poc_submission.py now prepares any extra submission whose template variable is set (HOLOFOOD_ISA_TEMPLATE_PATH, PTX_ISA_TEMPLATE_PATH).
  • MARS submodule bumped to the adapter changes.

Depends on elixir-europe/MARS#192

@bedroesb
bedroesb requested a review from kdp-cloud November 12, 2026 17:29
@kdp-cloud
kdp-cloud merged commit 74f072f into main Nov 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants