fix: resolve 7 bugs in graph, config-gen, rootfs, and CLI#19
Merged
fix: resolve 7 bugs in graph, config-gen, rootfs, and CLI#19
Conversation
- graph.py: remove 13 lines of dead code in topological_sort()
(first in_degree dict + setdefault loop were overwritten immediately)
- eos_config_generator.py: enforce 8 KiB floor on stage0_size so
128 KiB MCUs don't silently produce a 4 KiB bootloader slot
- eos_config_generator.py: add arch-aware _flash_base_for() helper
so nRF52 (0x00000000) and RP2040 (0x10000000) get correct bases
instead of the STM32-only hardcoded 0x08000000
- eos_config_generator.py: expand toolchain prefix map to cover arm64,
aarch64, riscv64, x86_64, mips; remove dead 'if ble: pass' no-op
- rootfs.py: reject home paths containing '..' to prevent directory
traversal out of the rootfs sandbox
- commands.py: replace str.replace('\', '/') with Path.as_posix()
for correct cross-platform CMake path generation
- commands.py: raise BuildError when a recipe's declared dependency
was not built, instead of silently omitting it from dep_dirs
All 55 tests pass (23 unit + 32 integration) in WSL Ubuntu.
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
hshanmug12
requested review from
maheshmunnangi,
rashmiadvani and
srpatcha
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Generated with Claude Code