Open
Conversation
Changed the behavior of border, and added a function that disable the water_border, when a player press "f"
Since we now border the water with a barrier, we don't need the physics layer in that scene
|
Play this branch at https://play.threadbare.game/branches/endlessm/champ_walk_on_water. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Closed
Reverted player movement back to it's old behavior
wjt
reviewed
Feb 11, 2026
project.godot
Outdated
| , Object(InputEventMouseButton,"resource_local_to_scene":false,"resource_name":"","device":-1,"window_id":0,"alt_pressed":false,"shift_pressed":false,"ctrl_pressed":false,"meta_pressed":false,"button_mask":1,"position":Vector2(92, 25),"global_position":Vector2(92, 54),"factor":1.0,"button_index":1,"canceled":false,"pressed":true,"double_click":false,"script":null) | ||
| ] | ||
| } | ||
| walk_on_water={ |
Member
There was a problem hiding this comment.
Please prefix this champ-specific action with champ_. (We don't normally have StoryQuest-specific actions here but I don't see a way around it.)
Changed name from walk_on_water to champ_walk_on_water for better clarity and coherence
Put the npc with walk_on_water code related question nearer to the spawn (so that player playing the game can see that npc as soon as they spawn)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created the ability to walk on water (should be key mapped to 'f' (for Fly))for the champ stealth scene. I brute forced it a little, however, it seems to be working as intended, and does not seems to be creating issues with other scene.
Resolves issue #1887