You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
package.json ships "nan": "^2.23.1". NAN is compiled into the addon (binding.gyprequire('nan')). A caret is not a pin: every consumer npm install re-resolves >=2.23.1 <3.0.0. This repo's lockfile hashing 2.28.0 does not bind dependents.
Pin nan to the reviewed exact version (currently 2.28.0). Prefer a shrinkwrap (or equivalent dependents actually apply) with integrity hashes. CI should install from the lockfile (npm ci), not a floating npm install.
Activity
enochgroot commentedon Sep 21, 2026
Implemented in #14 (branch
fix/review-open-6-13).enochgroot commentedon Sep 22, 2026
Tracked upstream: msgpack#25696
Closing this fork issue as a duplicate of that ticket. Numbering on enochgroot/msgpack-node is a different sequence from msgpack/msgpack-node.