feat: bundle manifests in code instead of loading from fs#273
feat: bundle manifests in code instead of loading from fs#273ghostdevv wants to merge 1 commit intoes-tooling:mainfrom
Conversation
|
i think this makes sense but it probably needs to happen in the next major since we have the json files in our package maybe you can help me get the new manifest structure over the line in #266 👀 and then the new major would have both |
They're still there - from a consumer point this shouldn't be a breaking change as only how the
👀 |
4a00430 to
0d98997
Compare
|
I think this makes sense and although this should not be a breaking change, even if it is, since we are releasing schema v3 we can merge this |
I realised when deploying code that imported
module-replacementsto Cloudflare that it was reading the manifests from the file system, which of course didn't work. This is the minimum change I could get to instead have the json become javascript without_ removing tshy or introducing a breaking change. I couldn't find if this had been talked about before, so apologies for the impromptu PR