ci: make repo web-only consistent (drop native build + editor steps)#43
Merged
Conversation
The native platform layer (NativePlatform/NativeFileSystem/FileDialog) and the editor/ workspace were deliberately removed in d9a08d8, but build.yml still ran a Linux native job (whose cmake configure died on the missing platform sources) and type-checked/tested a nonexistent editor/. Align CI and CMake with the web-only reality: - build.yml: drop the Linux (Ubuntu GCC) native job; remove the Type-check Editor and Run Editor tests steps; rename the test job to "Tests (SDK)". - CMakeLists.txt: drop the deleted native-platform source/header refs from the non-web branch so a plain cmake configure no longer errors on missing files. CI is now Web (Emscripten) + Tests (SDK).
Fold the two remaining master CI breakages into this web-only consistency PR so master goes green: - RenderFrameSubmit.cpp: widen submitSpineBatch's offset-index buffer u16 -> u32 to match appendIndices(const u32*) (the spine path #41 missed) — fixes the web build compile error. - examples: align 3 stale examples to the current SDK API: - audio-demo: events.hasEvent(e,'click') -> events.query('click').some(e=>e.target===entity) - ui-interaction: UIEvent.entity -> UIEvent.target - ui-controls: drop the obsolete ProgressBar-component animation (the SDK no longer exposes a queryable ProgressBar component; progress is now the createProgress widget). Scene-defined controls are unaffected. Verified locally: SDK typecheck + check-examples (18/18) pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This repo's CI (
build.yml, manual-dispatch only — no PR gating) had accumulated several unrelated pre-existing failures from the monorepo split + API evolution. This PR makesmastergreen again.What
Web-only consistency (
d9a08d87deliberately removeddesktop/,editor/, and the native platform stubs):build.yml: drop the Linux (Ubuntu GCC) native job (itscmakeconfigure died on the deletedplatform/native/*sources); remove theType-check Editor/Run Editor testssteps (noeditor/in this repo); rename the test job toTests (SDK).CMakeLists.txt: drop the deleted native-platform source/header refs from the non-web branch so a plaincmakeconfigure no longer errors.Web build fix:
RenderFrameSubmit.cpp: widensubmitSpineBatch's offset-index bufferu16 -> u32to matchappendIndices(const u32*)— the spine path that the fix(renderer): widen batch indices to u32 (RC5 — fixes silent >65535-vertex overflow) #41 u16→u32 widening missed (hard web compile error + the same silent >65535 overflow fix(renderer): widen batch indices to u32 (RC5 — fixes silent >65535-vertex overflow) #41 fixed elsewhere).Stale examples aligned to current SDK:
audio-demo:events.hasEvent(e,'click')→events.query('click').some(e => e.target === entity).ui-interaction:UIEvent.entity→UIEvent.target.ui-controls: drop the obsoleteProgressBar-component animation — the SDK no longer exposes a queryableProgressBarcomponent (progress is now thecreateProgresswidget). Scene-defined controls are unaffected.Verification
Locally: SDK typecheck OK,
check-examples18/18 pass. CI (build.yml) is now Web (Emscripten) + Tests (SDK), both green.