Repository navigation
ci: build docker images for PRs labelled build-docker-image - #270
Merged
Merged
Conversation
qu0b
approved these changes
Nov 18, 2026
samcm
approved these changes
Nov 18, 2026
barnabasbusa
approved these changes
Nov 18, 2026
There was a problem hiding this comment.
Summary
Adds a labelled-PR Docker workflow that builds the PR head on the runner (web assets + static binaries for amd64/arm64) and pushes branch-tagged images with the release Dockerfile, mirroring the dora pattern. The build itself checks out: make build-web runs before go build (required for //go:embed build/*), the dist-docker/linux/<arch>/checkpointz layout matches COPY $TARGETPLATFORM/checkpointz*, and the tag guard covers both v-prefixed and goreleaser-normalised version tags. The problems I found are confined to the manual-dispatch/documentation claims.
Issues
- 🟢
.github/workflows/build-dev.yaml:8— manual dispatch cannot reach a fork branch — see the thread on that line - 🟢
.github/workflows/build-dev.yaml:51— dispatch from a tag ref yields a mangled default tag — see the thread on that line
Reviewed @ c7e8f0fe
"If you don't have time to do it right, when will you have time to do it over?" — John Wooden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the labelled-PR docker build we already have in dora and other tools. Until now checkpointz images were only built by goreleaser on tags (or through a
release/*branch).How it works
build-docker-imagegets an image on every push, and when the label is added.ethpandaops/checkpointz:<branch>andethpandaops/checkpointz:<branch>-<short sha>, forlinux/amd64andlinux/arm64.pull_request, so they have no registry secrets. Dispatch it manually to publish a build of a fork branch.master,latest,*-latest, versions) are refused.Build
The image uses the same
goreleaser-scratch.Dockerfileas releases. The web frontend and both binaries are built on the runner (CGO_ENABLED=0, cross-compiled), and the Dockerfile only copies the binary, so no emulation is needed. The existing goreleaser release flow is untouched.It builds the PR head commit, not the PR/master merge commit.
Testing
Build steps run locally (binaries for both architectures, image built from the release Dockerfile and started). The workflow itself has not run in CI yet; labelling this PR will exercise it and publish
ethpandaops/checkpointz:pr-docker-builds.