Add memory tools to agent-mcp#45
Conversation
PR SummaryMedium Risk Overview Both tools require a registered (non-anonymous) agent session, default to agent scope/filtering, forward Reviewed by Cursor Bugbot for commit abf8f92. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit abf8f92. Configure here.
| orgID := sessionOrganizationID(state) | ||
| if orgID == "" { | ||
| return rc.registrationRequiredResult("recall memories"), recallOutput{}, nil | ||
| } |
There was a problem hiding this comment.
Misleading error when session lacks organization ID
Medium Severity
When sessionOrganizationID returns empty, both toolRecall and toolStoreMemory return registrationRequiredResult, which tells the user "Call evalops_register first." However, the user may already have a valid registered session — the actual problem is a missing workspace_id. Since workspace_id is optional in evalops_register, a user who registered without one enters a confusing loop: register → recall → "register first" → register again → same error. The error message doesn't indicate that a workspace/organization ID is the missing piece.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit abf8f92. Configure here.


Summary
evalops_recallandevalops_store_memoryMCP tools backed by the memory serviceTesting
Closes #34