chore: sync public mirror from internal#186
Conversation
PR SummaryMedium Risk Overview
Reviewed by Cursor Bugbot for commit d1f5a60. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbd56c5990
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
bbd56c5 to
89044f6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89044f66ba
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const mapResponses = await Promise.all( | ||
| mapThingIds.map((thingId) => | ||
| postCerebro<CerebroMapThingResponse>( |
There was a problem hiding this comment.
Make MapThing fetches resilient to per-thing failures
This Promise.all makes gatherMaestroSessionFactsContext fail fast if any single MapThing call errors (e.g., one timeout/404 among multiple thing IDs). In recordMaestroSessionRuntimeTrigger, that rejection is caught and factsContext is dropped entirely, so the runtime trigger loses all facts (including already-fetched Search/GetThing data) instead of degrading partially. This introduces a new all-or-nothing failure point for facts enrichment.
Useful? React with 👍 / 👎.
89044f6 to
d1f5a60
Compare
Summary
evalops/maestro-internalevalops/maestroas a generated public mirror of the private source of truthb8348e9436d58002960281544e85685c9c7e021e8a55f9467403be9dbe97126916a697e64e733c4a3file(s) to copy/update and1stale file(s) to delete0Source-of-truth status
Public Mirror Drift Audit
@evalops/maestrohttps://github.com/evalops/maestro-internal@main (b8348e9436d5)https://github.com/evalops/maestro@main (8a55f9467403)31public_projection_has_driftSample Changed Paths
Guidance
Let internal main generate and merge the public sync PR before relying on public main.
Drift sample
Public-only commits since last generated sync
Validation
sync-public-release-mirrorworkflow inpublic-treemodeSupersedes
b8348e9436d58002960281544e85685c9c7e021e