ci: avoid duplicate release tag auth headers#136
Conversation
PR SummaryLow Risk Overview This avoids multiple auth paths when pushing release tags, relying on the workflow’s other credential setup to handle tag/release publishing cleanly. Reviewed by Cursor Bugbot for commit e2c22b6. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit e2c22b6. Configure here.
| uses: actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: false |
There was a problem hiding this comment.
Tag fetch runs before git auth is configured
Medium Severity
The git fetch --force --tags origin step on line 26 runs before setup-go-service (line 29) configures git authentication. With the newly added persist-credentials: false, checkout no longer leaves credentials in the git config. The setup-go-service composite action is what configures the extraheader auth (via git config --global), but it runs two steps later. For a private repository, this fetch will fail with an authentication error. Even for a public repo this creates a fragile ordering dependency.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e2c22b6. Configure here.


Summary
Validation