Skip to content

ci: avoid duplicate release tag auth headers#136

Merged
haasonsaas merged 1 commit intomainfrom
codex/fix-release-tag-auth
Apr 20, 2026
Merged

ci: avoid duplicate release tag auth headers#136
haasonsaas merged 1 commit intomainfrom
codex/fix-release-tag-auth

Conversation

@haasonsaas
Copy link
Copy Markdown
Contributor

Summary

  • disables checkout credential persistence in the release workflow
  • leaves the shared setup-go-service GitHub module credential as the single auth path for tag pushes
  • fixes the v0.1.49 release failure caused by duplicate Authorization headers

Validation

  • actionlint .github/workflows/release.yml
  • git diff --check

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 20, 2026

PR Summary

Low Risk
Low risk workflow-only change that adjusts GitHub Actions authentication behavior during releases. Main risk is misconfigured credentials could prevent tag pushes or releases.

Overview
The release workflow now sets actions/checkout to persist-credentials: false, preventing the runner from keeping the checkout token in the git config.

This avoids multiple auth paths when pushing release tags, relying on the workflow’s other credential setup to handle tag/release publishing cleanly.

Reviewed by Cursor Bugbot for commit e2c22b6. Bugbot is set up for automated code reviews on this repo. Configure here.

@haasonsaas haasonsaas merged commit f7171fd into main Apr 20, 2026
7 checks passed
@haasonsaas haasonsaas deleted the codex/fix-release-tag-auth branch April 20, 2026 21:05
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.

Reviewed by Cursor Bugbot for commit e2c22b6. Configure here.

uses: actions/checkout@v6
with:
fetch-depth: 0
persist-credentials: false
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag fetch runs before git auth is configured

Medium Severity

The git fetch --force --tags origin step on line 26 runs before setup-go-service (line 29) configures git authentication. With the newly added persist-credentials: false, checkout no longer leaves credentials in the git config. The setup-go-service composite action is what configures the extraheader auth (via git config --global), but it runs two steps later. For a private repository, this fetch will fail with an authentication error. Even for a public repo this creates a fragile ordering dependency.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e2c22b6. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant