Skip to content

chore: sync uutils/coreutils argument surfaces and vendored modules - #2918

Open
chaliy wants to merge 1 commit into
mainfrom
chore/coreutils-args-drift
Open

chaliy wants to merge 1 commit into
mainfrom
chore/coreutils-args-drift

Conversation

@chaliy

@chaliy chaliy commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Automated regeneration of argument surfaces and vendored modules
ported from uutils/coreutils.

Source revision: 77b3b4170 (was 6a7d199ed)
Utilities: cat ls mktemp od readlink realpath shuf stat tac tee truncate
Vendored modules: format
Trigger: .github/workflows/coreutils-args-drift.yml

This PR bumps UUTILS_REVISION in
crates/bashkit/src/builtins/generated/mod.rs, the matching
<util>_args.rs files, and any vendored module trees
atomically — args codegen, module-vendor mode, and the
body-drift harness all stay aligned to the same rev.

Review the diff to confirm whether upstream:

  • Added flags we should now expose
  • Removed/renamed flags we should drop or migrate
  • Reworded help text in user-visible ways
  • Changed body code in vendored modules (e.g. format/)

Squash-merge as a human so the merge commit is attributed
correctly per AGENTS.md. Intermediate bot commits in this PR
are discarded by squash.

Design: knowledge/runtimes/coreutils-args-port.md.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

… modules

Regenerated by `bashkit-coreutils-port` against uutils/coreutils@77b3b4170.

Utilities: cat ls mktemp od readlink realpath shuf stat tac tee truncate

Vendored modules: format
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
bashkit c99ad97 Commit Preview URL

Branch Preview URL
Nov 13 2026, 10:20 AM

@bashkit-pr-reviewer

Copy link
Copy Markdown

Review summary (PR #2918, head c99ad97b51e8ec310f8e3de99939b1989e66fd6f)

Verdict: looks good — no findings. A pure upstream drift sync: 43 generated files re-pointed from uutils 6a7d199ed to 77b3b4170, and the one non-comment hunk (generated/format/spec.rs, %q/QuotedString arm) faithfully ports upstream's new QuotingStyle::SHELL_ESCAPE.always_quote(has_brace) + locale_aware_escape_name + as_encoded_bytes spelling.

Why the behavior change is safe: the new always_quote flag lands on bashkit's handwritten shim (generated/format_support.rs:96-118), which is deliberately a no-op returning the style unchanged and routing every shell style through the bash-faithful shell_quote. The divergence is documented as a drift decision in code comments, and is pinned by pre-existing tests: format_support.rs:275 always_quote_does_not_change_how_braces_are_escaped and printf.rs:1011 quoted_string_escapes_braces_the_way_bash_does (a{b → a\{b, never 'a{b'). So the vendored call site tracks upstream while output stays bash's.

Context read beyond the diff: AGENTS.md, knowledge/runtimes/coreutils-args-port.md (drift must stay comment/revision-only with decisions in comments — satisfied), format/spec.rs:299-380, format_support.rs:41-262 (shim, os_str_as_bytes, locale_aware_escape_name, shell_quote), and printf.rs %q tests. No sandbox/VFS/network surface touched; as_encoded_bytes and is_ok_and are already used in-tree, so no MSRV concern. The full diff was visible (truncated: false).

No review posted (no findings per workflow).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant