feat(rpc): reconstruct attester commits deterministically (Part 3)#396
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Base automatically changed from
split/02-vote-verification
to
split/01-genesis-attester-set
June 25, 2026 08:42
randygrok
merged commit 7631cef
into
split/01-genesis-attester-set
16 of 17 checks passed
randygrok
added a commit
that referenced
this pull request
Jun 30, 2026
* feat(network): load fixed attester set from genesis * refactor(network): keep attester set fixed after genesis * refactor(network): remove inactive pruning code * feat(network): verify attester votes (#395) * feat(rpc): reconstruct attester commits deterministically (Part 3) (#396) * feat(network): verify attester votes * feat(rpc): reconstruct attester commits deterministically * feat(attester): attest from fixed genesis set (Part 4) (#397) * feat(network): verify attester votes * feat(rpc): reconstruct attester commits deterministically * feat(attester): attest from fixed genesis set * test(integration): cover attested IBC commits (Part 5) (#398) * feat(network): verify attester votes * feat(rpc): reconstruct attester commits deterministically * feat(attester): attest from fixed genesis set * test(integration): cover attested IBC commits * fix: align attester light client RPC data (#409) * feat(network): verify attester votes * feat(rpc): reconstruct attester commits deterministically * feat(attester): attest from fixed genesis set * test(integration): cover attested IBC commits * fix: preserve attester query errors and vote address * test: add multi-attester docker e2e * fix: fail attester startup without block id provider * fix: format server test imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is Part 3 of the prod-readiness split, stacked on #395.
Changes:
AttesterSetquery endpoint for the fixed ordered attester set./validatorsreturn the same full attester set used by/commit.Validation
go test ./pkg/adapter ./pkg/rpc/core ./modules/network/...